From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-pci <linux-pci@vger.kernel.org>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] PCI: rcar-pcie: Remove Gen2 designation from Kconfig
Date: Thu, 31 Mar 2016 09:22:35 +0900 [thread overview]
Message-ID: <20160331002234.GA27282@verge.net.au> (raw)
In-Reply-To: <CAMuHMdUYUFGho2jN-mxa143MnGLZWtrx+Rg5Ba4W_BG4iJu4zg@mail.gmail.com>
On Tue, Mar 29, 2016 at 08:50:55AM +0200, Geert Uytterhoeven wrote:
> On Tue, Mar 29, 2016 at 5:43 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > It appears that Gen2 is a misnomer for the R-Car PCIE driver
> > which also supports Gen 1 and Gen 3 SoCs. Accordingly, drop Gen 2
> > from the help text and Kconfig symbol.
> >
> > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > Bjorn, if this patch is acceptable I would like to request that we
> > co-ordinate things so that I can queue-up corresponding updates for
> > arm and arm64 defconfigs in the same release. From my point of view
> > v4.7 would make sense.
> > ---
> > drivers/pci/host/Kconfig | 4 ++--
> > drivers/pci/host/Makefile | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> > index 7a0780d56d2d..9109c6c5298c 100644
> > --- a/drivers/pci/host/Kconfig
> > +++ b/drivers/pci/host/Kconfig
> > @@ -69,11 +69,11 @@ config PCI_RCAR_GEN2
> > There are 3 internal PCI controllers available with a single
> > built-in EHCI/OHCI host controller present on each one.
> >
> > -config PCI_RCAR_GEN2_PCIE
> > +config PCI_RCAR_PCIE
>
> Following the pattern in drivers/pci/host/Kconfig, I think this symbol should
> be called PCIE_RCAR.
Short is nice :)
I will send v2.
prev parent reply other threads:[~2016-03-31 0:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 3:43 [PATCH] PCI: rcar-pcie: Remove Gen2 designation from Kconfig Simon Horman
2016-03-29 6:50 ` Geert Uytterhoeven
2016-03-31 0:22 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331002234.GA27282@verge.net.au \
--to=horms@verge.net.au \
--cc=bhelgaas@google.com \
--cc=geert@linux-m68k.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).