From: "Michael Büsch" <m@bues.ch>
To: Lukas Wunner <lukas@wunner.de>
Cc: linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org
Subject: Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm
Date: Thu, 31 Mar 2016 21:09:36 +0200 [thread overview]
Message-ID: <20160331210936.6b195135@wiggum> (raw)
In-Reply-To: <E1akxli-00030z-Jz@bombadil.infradead.org>
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
On Tue, 29 Mar 2016 19:41:30 +0200
Lukas Wunner <lukas@wunner.de> wrote:
> +static void quirk_apple_b43_reset(struct pci_dev *dev)
> +{
> + void __iomem *mmio;
> +
> + if (!dmi_match(DMI_BOARD_VENDOR, "Apple Inc.") || !dev->bus->self ||
> + pci_pcie_type(dev->bus->self) != PCI_EXP_TYPE_ROOT_PORT)
> + return;
> +
> + mmio = pci_iomap(dev, 0, 0);
> + if (!mmio) {
> + pr_err("b43 quirk: Cannot iomap device, IRQ storm ahead\n");
> + return;
> + }
> + iowrite32(BCMA_RESET_CTL_RESET,
> + mmio + (1 * BCMA_CORE_SIZE) + BCMA_RESET_CTL);
> + pci_iounmap(dev, mmio);
> +}
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM, 0x4331, quirk_apple_b43_reset);
Looks good, as long as the wireless core is always guaranteed to be
the second core on that PCI device.
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next parent reply other threads:[~2016-03-31 19:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1akxli-00030z-Jz@bombadil.infradead.org>
2016-03-31 19:09 ` Michael Büsch [this message]
[not found] <E1akxli-00030z-BC@bombadil.infradead.org>
2016-03-31 23:13 ` [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm Chris Bainbridge
2016-04-01 4:59 ` Michael Büsch
2016-04-01 22:46 ` Lukas Wunner
2016-04-02 7:30 ` Michael Büsch
[not found] ` <CA+Y=x3=cLDHc7PK5h9n=ixdgVKWdVSu_v+-7jHJ-vBnDrv4sgg@mail.gmail.com>
2016-04-03 11:49 ` Lukas Wunner
2016-04-07 12:04 ` Andrew Worsley
2016-04-10 10:09 ` Andrew Worsley
2016-04-12 18:32 ` Lukas Wunner
2016-04-13 20:42 ` Andrew Worsley
2016-04-24 17:04 ` Lukas Wunner
2016-05-23 14:42 ` Lukas Wunner
2016-05-24 23:38 ` Chris Bainbridge
2016-03-29 18:20 Lukas Wunner
2016-03-31 18:51 ` Rafał Miłecki
2016-04-05 19:40 ` Bjorn Helgaas
2016-04-05 19:49 ` Michael Büsch
2016-04-06 13:31 ` Bjorn Helgaas
2016-04-06 15:17 ` Michael Büsch
2016-04-06 21:36 ` Lukas Wunner
2016-04-05 19:59 ` Matthew Garrett
2016-04-06 11:28 ` Andrew Worsley
2016-04-06 21:30 ` Lukas Wunner
2016-04-06 22:19 ` Matthew Garrett
2016-04-09 12:00 ` Matt Fleming
2016-04-24 16:58 ` Lukas Wunner
-- strict thread matches above, loose matches on Subject: below --
2016-03-29 17:46 Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331210936.6b195135@wiggum \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).