From: Bjorn Helgaas <helgaas@kernel.org>
To: Jordan Hargrave <Jordan_Hargrave@dell.com>
Cc: bhelgaas@google.com, alexander.duyck@gmail.com,
linux-pci@vger.kernel.org, babu.moger@oracle.com, hare@suse.de,
linux-kernel@vger.kernel.org, jharg93@gmail.com
Subject: Re: [PATCH 2/2] Create sysfs entries for PCI VPDI and VPDR tags
Date: Sun, 10 Apr 2016 16:27:02 -0500 [thread overview]
Message-ID: <20160410212702.GB5852@localhost> (raw)
In-Reply-To: <1455827464-11398-1-git-send-email-Jordan_Hargrave@dell.com>
On Thu, Feb 18, 2016 at 02:31:04PM -0600, Jordan Hargrave wrote:
> The VPD-R is a readonly area of the PCI Vital Product Data region.
> There are some standard keywords for serial number, manufacturer,
> and vendor-specific values. Dell Servers use a vendor-specific
> tag to store number of ports and port mapping of partitioned NICs.
>
> info = VPD-Info string
> PN = Part Number
> SN = Serial Number
> MN = Manufacturer ID
> Vx = Vendor-specific (x=0..9 A..Z)
>
> This creates a sysfs subdirectory in the pci device: vpdattr with
> 'info', 'EC', 'SN', 'V0', etc. files containing the tag values.
>
> Added pci.h patch
>
> Signed-off-by: Jordan Hargrave <Jordan_Hargrave@dell.com>
> ---
> include/linux/pci.h | 3 +
> 1 files changed, 3 insertions(+)
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 8135a2f..c1313b1 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -372,6 +372,9 @@ struct pci_dev {
> const struct attribute_group **msi_irq_groups;
> #endif
> struct pci_vpd *vpd;
> + int vpdr_len;
> + u8 *vpdr_data;
> + char *vpdi_data;
This should be squashed into the patch that uses the fields you're adding.
> #ifdef CONFIG_PCI_ATS
> union {
> struct pci_sriov *sriov; /* SR-IOV capability related */
> --
> 2.5.0
>
prev parent reply other threads:[~2016-04-10 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 20:31 [PATCH 2/2] Create sysfs entries for PCI VPDI and VPDR tags Jordan Hargrave
2016-04-10 21:27 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160410212702.GB5852@localhost \
--to=helgaas@kernel.org \
--cc=Jordan_Hargrave@dell.com \
--cc=alexander.duyck@gmail.com \
--cc=babu.moger@oracle.com \
--cc=bhelgaas@google.com \
--cc=hare@suse.de \
--cc=jharg93@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).