From: Joerg Roedel <jroedel@suse.de>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: stable@vger.kernel.org, ОлегМороз <oleg.moroz@mcc.vniiem.ru>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Sunjin Yang" <fan4326@gmail.com>, "Rob Groner" <rgroner@rtd.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jiang Liu" <jiang.liu@linux.intel.com>
Subject: Re: [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and
Date: Thu, 14 Apr 2016 17:50:44 +0200 [thread overview]
Message-ID: <20160414155044.GB3886@suse.de> (raw)
In-Reply-To: <20160413055439.6877.68183.stgit@bhelgaas-glaptop2.roam.corp.google.com>
Hi Bjorn,
On Wed, Apr 13, 2016 at 12:56:59AM -0500, Bjorn Helgaas wrote:
> We reverted the following changes from v4.5 to fix a regression:
>
> 8affb487d4a4 ("x86/PCI: Don't alloc pcibios-irq when MSI is enabled")
> 811a4e6fce09 ("PCI: Add helpers to manage pci_dev->irq and pci_dev->irq_managed")
> 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()")
Do you have a link to the thread about these issues? I'd like to have a
look at what has been tried to solve the regressions before the revert.
I had a look at commit 991de2e59090 and noted that the main difference
it introduces is that the pcibios-irq is allocated earlier (probe time,
before the commit it was pci_enable_device() time). In fact, it is now
allocated before pci_enable_resources() has been called on the device
(as far as I can see). I wonder if the regression can be fixed by
also moving pci_enable_resources() to probe time.
Regards,
Joerg
next prev parent reply other threads:[~2016-04-14 15:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 5:56 [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and Bjorn Helgaas
2016-04-13 5:57 ` [PATCH 1/3] Revert "x86/PCI: Don't alloc pcibios-irq when MSI is enabled" Bjorn Helgaas
2016-04-13 5:57 ` [PATCH 2/3] Revert "PCI: Add helpers to manage pci_dev->irq and pci_dev->irq_managed" Bjorn Helgaas
2016-04-13 5:57 ` [PATCH 3/3] Revert "PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()" Bjorn Helgaas
2016-04-14 15:50 ` Joerg Roedel [this message]
2016-04-15 15:08 ` [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and Bjorn Helgaas
2016-04-18 11:50 ` Joerg Roedel
2016-04-18 14:43 ` Bjorn Helgaas
2016-04-19 9:41 ` Joerg Roedel
2016-04-18 1:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414155044.GB3886@suse.de \
--to=jroedel@suse.de \
--cc=bhelgaas@google.com \
--cc=fan4326@gmail.com \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=oleg.moroz@mcc.vniiem.ru \
--cc=rafael@kernel.org \
--cc=rgroner@rtd.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).