From: Lukas Wunner <lukas@wunner.de>
To: Keith Busch <keith.busch@intel.com>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] pcie: Add driver for Downstream Port Containment
Date: Tue, 26 Apr 2016 23:05:58 +0200 [thread overview]
Message-ID: <20160426210558.GB17561@wunner.de> (raw)
In-Reply-To: <1461703693-29400-1-git-send-email-keith.busch@intel.com>
Hi Keith,
On Tue, Apr 26, 2016 at 02:48:13PM -0600, Keith Busch wrote:
> --- a/drivers/pci/pcie/portdrv.h
> +++ b/drivers/pci/pcie/portdrv.h
> @@ -11,7 +11,7 @@
>
> #include <linux/compiler.h>
>
> -#define PCIE_PORT_DEVICE_MAXSERVICES 4
> +#define PCIE_PORT_DEVICE_MAXSERVICES 5
You're adding a fifth port service yet the name of port service devices
encodes the service type in one nibble, so there's only room for four
service types.
You need to amend your patch to fixup get_descriptor_id() in portdrv.h
as well as dev_set_name() in portdrv_core.c to cope with more than four
service types, as I've done in this commit:
https://github.com/l1k/linux/commit/b688d6e4873ab082e5916b1a993bc1d38c6f4178
You may also want to fixup these small nits in the commit message:
> This adds driver support for root and downstream ports that implement
> the Downstream Port PCI-Express extended capability. DPC is an optional
^
Containment
> capability to contained uncorrectable errors below a downstream port.
^
contain
>
> When a DPC is triggered due to receipt of an uncorrectable error message,
> the DPC driver will schedule removal for all downstream devices as DPC
> capable ports disable downstream links. This may happen concurrently
> with a PCI-e hotplug driver if enabled. After the downstream devices
> are removed, the DPC driver will clear the status and interrupt bits
^
and
> the link may retrain for a newly connected device.
Best regards,
Lukas
next prev parent reply other threads:[~2016-04-26 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 20:48 [PATCH] pcie: Add driver for Downstream Port Containment Keith Busch
2016-04-26 21:05 ` Lukas Wunner [this message]
2016-04-26 21:17 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426210558.GB17561@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).