From: Keith Busch <keith.busch@intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] pcie: Add driver for Downstream Port Containment
Date: Tue, 26 Apr 2016 21:17:28 +0000 [thread overview]
Message-ID: <20160426211727.GB24243@localhost.localdomain> (raw)
In-Reply-To: <20160426210558.GB17561@wunner.de>
On Tue, Apr 26, 2016 at 11:05:58PM +0200, Lukas Wunner wrote:
> You need to amend your patch to fixup get_descriptor_id() in portdrv.h
> as well as dev_set_name() in portdrv_core.c to cope with more than four
> service types, as I've done in this commit:
>
> https://github.com/l1k/linux/commit/b688d6e4873ab082e5916b1a993bc1d38c6f4178
Thanks for the pointer. I hadn't noticed since it seemed to work as-is,
but I see this could generate duplicate names with the PME service.
> You may also want to fixup these small nits in the commit message:
My proof-reading is atrocious. Thanks for the fixes.
Will send a new version.
prev parent reply other threads:[~2016-04-26 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 20:48 [PATCH] pcie: Add driver for Downstream Port Containment Keith Busch
2016-04-26 21:05 ` Lukas Wunner
2016-04-26 21:17 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426211727.GB24243@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).