From: Bjorn Helgaas <helgaas@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms+renesas@verge.net.au>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: rcar: select PCI_MSI_IRQ_DOMAIN
Date: Mon, 2 May 2016 12:04:43 -0500 [thread overview]
Message-ID: <20160502170443.GE24851@localhost> (raw)
In-Reply-To: <1460837798-1239513-1-git-send-email-arnd@arndb.de>
On Sat, Apr 16, 2016 at 10:15:46PM +0200, Arnd Bergmann wrote:
> The R-CAR PCIe driver requires the use of irq domains for its
> MSI code:
>
> drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_msi_irq':
> drivers/pci/host/pcie-rcar.c:635:9: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
> drivers/pci/host/pcie-rcar.c: In function 'rcar_msi_setup_irq':
> drivers/pci/host/pcie-rcar.c:666:8: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
> drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_enable_msi':
> drivers/pci/host/pcie-rcar.c:725:16: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration]
> drivers/pci/host/pcie-rcar.c:725:14: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
> msi->domain = irq_domain_add_linear(pcie->dev->of_node, INT_PCI_MSI_NR,
> ^
> drivers/pci/host/pcie-rcar.c:762:2: error: implicit declaration of function 'irq_domain_remove' [-Werror=implicit-function-declaration]
>
> This ensures that the feature is always enabled by adding a
> Kconfig select statement. This is not consistent with what the
> other drivers do at the moment, but I have another patch that
> changes them to do it like this one, which is more logical.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied with Simon's ack to pci/host-rcar for v4.7, thanks!
> ---
> drivers/pci/host/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 169c545bf70a..6d642aa390b0 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -72,6 +72,8 @@ config PCI_RCAR_GEN2
> config PCI_RCAR_GEN2_PCIE
> bool "Renesas R-Car PCIe controller"
> depends on ARCH_RENESAS || (ARM && COMPILE_TEST)
> + select PCI_MSI
> + select PCI_MSI_IRQ_DOMAIN
> help
> Say Y here if you want PCIe controller support on R-Car Gen2 SoCs.
>
> --
> 2.7.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-05-02 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-16 20:15 [PATCH] PCI: rcar: select PCI_MSI_IRQ_DOMAIN Arnd Bergmann
2016-04-16 23:33 ` Simon Horman
2016-05-02 17:04 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502170443.GE24851@localhost \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).