* [PATCH] PCI: rcar: select PCI_MSI_IRQ_DOMAIN
@ 2016-04-16 20:15 Arnd Bergmann
2016-04-16 23:33 ` Simon Horman
2016-05-02 17:04 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-04-16 20:15 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Arnd Bergmann, Rob Herring, Geert Uytterhoeven, Simon Horman,
linux-pci, linux-kernel
The R-CAR PCIe driver requires the use of irq domains for its
MSI code:
drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_msi_irq':
drivers/pci/host/pcie-rcar.c:635:9: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
drivers/pci/host/pcie-rcar.c: In function 'rcar_msi_setup_irq':
drivers/pci/host/pcie-rcar.c:666:8: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_enable_msi':
drivers/pci/host/pcie-rcar.c:725:16: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration]
drivers/pci/host/pcie-rcar.c:725:14: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
msi->domain = irq_domain_add_linear(pcie->dev->of_node, INT_PCI_MSI_NR,
^
drivers/pci/host/pcie-rcar.c:762:2: error: implicit declaration of function 'irq_domain_remove' [-Werror=implicit-function-declaration]
This ensures that the feature is always enabled by adding a
Kconfig select statement. This is not consistent with what the
other drivers do at the moment, but I have another patch that
changes them to do it like this one, which is more logical.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pci/host/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index 169c545bf70a..6d642aa390b0 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -72,6 +72,8 @@ config PCI_RCAR_GEN2
config PCI_RCAR_GEN2_PCIE
bool "Renesas R-Car PCIe controller"
depends on ARCH_RENESAS || (ARM && COMPILE_TEST)
+ select PCI_MSI
+ select PCI_MSI_IRQ_DOMAIN
help
Say Y here if you want PCIe controller support on R-Car Gen2 SoCs.
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: rcar: select PCI_MSI_IRQ_DOMAIN
2016-04-16 20:15 [PATCH] PCI: rcar: select PCI_MSI_IRQ_DOMAIN Arnd Bergmann
@ 2016-04-16 23:33 ` Simon Horman
2016-05-02 17:04 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2016-04-16 23:33 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bjorn Helgaas, Rob Herring, Geert Uytterhoeven, linux-pci,
linux-kernel
On Sat, Apr 16, 2016 at 10:15:46PM +0200, Arnd Bergmann wrote:
> The R-CAR PCIe driver requires the use of irq domains for its
> MSI code:
>
> drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_msi_irq':
> drivers/pci/host/pcie-rcar.c:635:9: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
> drivers/pci/host/pcie-rcar.c: In function 'rcar_msi_setup_irq':
> drivers/pci/host/pcie-rcar.c:666:8: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
> drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_enable_msi':
> drivers/pci/host/pcie-rcar.c:725:16: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration]
> drivers/pci/host/pcie-rcar.c:725:14: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
> msi->domain = irq_domain_add_linear(pcie->dev->of_node, INT_PCI_MSI_NR,
> ^
> drivers/pci/host/pcie-rcar.c:762:2: error: implicit declaration of function 'irq_domain_remove' [-Werror=implicit-function-declaration]
>
> This ensures that the feature is always enabled by adding a
> Kconfig select statement. This is not consistent with what the
> other drivers do at the moment, but I have another patch that
> changes them to do it like this one, which is more logical.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This seems reasonable to me:
Acked-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/pci/host/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 169c545bf70a..6d642aa390b0 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -72,6 +72,8 @@ config PCI_RCAR_GEN2
> config PCI_RCAR_GEN2_PCIE
> bool "Renesas R-Car PCIe controller"
> depends on ARCH_RENESAS || (ARM && COMPILE_TEST)
> + select PCI_MSI
> + select PCI_MSI_IRQ_DOMAIN
> help
> Say Y here if you want PCIe controller support on R-Car Gen2 SoCs.
>
> --
> 2.7.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: rcar: select PCI_MSI_IRQ_DOMAIN
2016-04-16 20:15 [PATCH] PCI: rcar: select PCI_MSI_IRQ_DOMAIN Arnd Bergmann
2016-04-16 23:33 ` Simon Horman
@ 2016-05-02 17:04 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2016-05-02 17:04 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bjorn Helgaas, Rob Herring, Geert Uytterhoeven, Simon Horman,
linux-pci, linux-kernel
On Sat, Apr 16, 2016 at 10:15:46PM +0200, Arnd Bergmann wrote:
> The R-CAR PCIe driver requires the use of irq domains for its
> MSI code:
>
> drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_msi_irq':
> drivers/pci/host/pcie-rcar.c:635:9: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
> drivers/pci/host/pcie-rcar.c: In function 'rcar_msi_setup_irq':
> drivers/pci/host/pcie-rcar.c:666:8: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
> drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_enable_msi':
> drivers/pci/host/pcie-rcar.c:725:16: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration]
> drivers/pci/host/pcie-rcar.c:725:14: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
> msi->domain = irq_domain_add_linear(pcie->dev->of_node, INT_PCI_MSI_NR,
> ^
> drivers/pci/host/pcie-rcar.c:762:2: error: implicit declaration of function 'irq_domain_remove' [-Werror=implicit-function-declaration]
>
> This ensures that the feature is always enabled by adding a
> Kconfig select statement. This is not consistent with what the
> other drivers do at the moment, but I have another patch that
> changes them to do it like this one, which is more logical.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied with Simon's ack to pci/host-rcar for v4.7, thanks!
> ---
> drivers/pci/host/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 169c545bf70a..6d642aa390b0 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -72,6 +72,8 @@ config PCI_RCAR_GEN2
> config PCI_RCAR_GEN2_PCIE
> bool "Renesas R-Car PCIe controller"
> depends on ARCH_RENESAS || (ARM && COMPILE_TEST)
> + select PCI_MSI
> + select PCI_MSI_IRQ_DOMAIN
> help
> Say Y here if you want PCIe controller support on R-Car Gen2 SoCs.
>
> --
> 2.7.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-02 17:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-16 20:15 [PATCH] PCI: rcar: select PCI_MSI_IRQ_DOMAIN Arnd Bergmann
2016-04-16 23:33 ` Simon Horman
2016-05-02 17:04 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).