From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.136]:57810 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755528AbcEFQfZ (ORCPT ); Fri, 6 May 2016 12:35:25 -0400 Date: Fri, 6 May 2016 11:35:10 -0500 From: Bjorn Helgaas To: Christoph Hellwig Cc: agordeev@redhat.com, pjw@netapp.com, axboe@fb.com, keith.busch@intel.com, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 1/2] PCI: Provide sensible irq vector alloc/free routines Message-ID: <20160506163510.GA20754@localhost> References: <1462457096-19795-1-git-send-email-hch@lst.de> <1462457096-19795-2-git-send-email-hch@lst.de> <20160506160408.GB15666@localhost> <20160506162823.GB7999@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20160506162823.GB7999@lst.de> Sender: linux-pci-owner@vger.kernel.org List-ID: On Fri, May 06, 2016 at 06:28:23PM +0200, Christoph Hellwig wrote: > On Fri, May 06, 2016 at 11:04:08AM -0500, Bjorn Helgaas wrote: > > I like this a lot. One relatively minor comment below. > > Do you want this addressed? The problem is that I probably will also > need something like this flags argument for introducing the irq spreading > as we can't simply do it for all callers directly. If you take > the patch as-is I'd be happy to do another pass later to remove it > and look into different no-MSI quirking once we're done with the > MSI-X spreading work. I don't know what sort of clues you'll need for IRQ spreading, but that sounds like a good reason for the argument. So if you will need the flags argument for something else, then I think it's OK as-is. Bjorn