From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCHv4] pcie: Add driver for Downstream Port Containment
Date: Fri, 6 May 2016 13:06:46 -0400 [thread overview]
Message-ID: <20160506170646.GH8503@localhost.localdomain> (raw)
In-Reply-To: <20160506162027.GA20010@localhost>
On Fri, May 06, 2016 at 11:20:27AM -0500, Bjorn Helgaas wrote:
> On Mon, May 02, 2016 at 03:25:38PM -0500, Bjorn Helgaas wrote:
> >
> > This looks like a typo; I assume you meant:
> >
> > ctl &= ~(PCI_EXP_DPC_CTL_EN_NONFATAL | PCI_EXP_DPC_CTL_INT_EN);
> >
> > so we *clear* (not set) these bits on removal. I made this change on
> > my branch.
>
> Hi Keith, can you double-check and confirm that this was indeed a typo
> and that what's in my next branch is correct?
>
> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=next&id=26e515713342b6f7c553aa3c66b21c6ab7cf82af
Hi Bjorn,
You are right, that was a typo. Thanks for the catch and the fix.
next prev parent reply other threads:[~2016-05-06 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 22:24 [PATCHv4] pcie: Add driver for Downstream Port Containment Keith Busch
2016-05-02 20:25 ` Bjorn Helgaas
2016-05-06 16:20 ` Bjorn Helgaas
2016-05-06 17:06 ` Keith Busch [this message]
2016-05-11 16:08 ` Bjorn Helgaas
2016-05-11 17:06 ` Keith Busch
2016-05-11 18:28 ` Bjorn Helgaas
2016-05-11 19:55 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506170646.GH8503@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).