Build warning regression (104daa71b396 ("PCI: Determine actual VPD size on first access"))

Build warning regression (104daa71b396 ("PCI: Determine actual VPD size on first access"))

[Bjorn Helgaas]

Hi Hannes,

Geert's list of build regressions and improvements
(http://lkml.kernel.org/r/1462782250-6231-1-git-send-email-geert@linux-m68k.org)
shows these new warnings:

  drivers/pci/access.c: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int' [-Wformat=]:  => 318:8
  drivers/pci/access.c: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'unsigned int' [-Wformat=]:  => 340:6

which I think are due to 104daa71b396 ("PCI: Determine actual VPD size on
first access").

Would you mind fixing those up and sending me a patch?  These were in
the v4.6-rc1 regressions email, and I should have noticed then, but I
didn't.

Bjorn

Re: Build warning regression (104daa71b396 ("PCI: Determine actual VPD size on first access"))

[Hannes Reinecke]

On 05/09/2016 09:54 PM, Bjorn Helgaas wrote:
> Hi Hannes,
> 
> Geert's list of build regressions and improvements
> (http://lkml.kernel.org/r/1462782250-6231-1-git-send-email-geert@linux-m68k.org)
> shows these new warnings:
> 
>   drivers/pci/access.c: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int' [-Wformat=]:  => 318:8
>   drivers/pci/access.c: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'unsigned int' [-Wformat=]:  => 340:6
> 
> which I think are due to 104daa71b396 ("PCI: Determine actual VPD size on
> first access").
> 
> Would you mind fixing those up and sending me a patch?  These were in
> the v4.6-rc1 regressions email, and I should have noticed then, but I
> didn't.
> 
This is curious.
The code has this:

size_t off = 0;

...

dev_warn(&dev->dev,
	"invalid large VPD tag %02x size at offset %zu",
	tag, off + 1);

Which, as per my reading, suggests that the last argument to
dev_warn() is of type size_t.

Which tree has generated the above warning?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

Re: Build warning regression (104daa71b396 ("PCI: Determine actual VPD size on first access"))

[Bjorn Helgaas]

[+cc Geert]

On Tue, May 10, 2016 at 08:09:53AM +0200, Hannes Reinecke wrote:
> On 05/09/2016 09:54 PM, Bjorn Helgaas wrote:
> > Hi Hannes,
> > 
> > Geert's list of build regressions and improvements
> > (http://lkml.kernel.org/r/1462782250-6231-1-git-send-email-geert@linux-m68k.org)
> > shows these new warnings:
> > 
> >   drivers/pci/access.c: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int' [-Wformat=]:  => 318:8
> >   drivers/pci/access.c: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'unsigned int' [-Wformat=]:  => 340:6
> > 
> > which I think are due to 104daa71b396 ("PCI: Determine actual VPD size on
> > first access").
> > 
> > Would you mind fixing those up and sending me a patch?  These were in
> > the v4.6-rc1 regressions email, and I should have noticed then, but I
> > didn't.
> > 
> This is curious.
> The code has this:
> 
> size_t off = 0;
> 
> ...
> 
> dev_warn(&dev->dev,
> 	"invalid large VPD tag %02x size at offset %zu",
> 	tag, off + 1);
> 
> Which, as per my reading, suggests that the last argument to
> dev_warn() is of type size_t.
> 
> Which tree has generated the above warning?

Yeah, it wasn't obvious to me how this would happen either.  From
Geert's original email, I think the tree is v4.6-rc7, i.e.,
44549e8f5eea4e0a41b487b63e616cb089922b99.

Geert, can you tell which config generated this warning?

Re: Build warning regression (104daa71b396 ("PCI: Determine actual VPD size on first access"))

[Geert Uytterhoeven]

Hi Bjorn,

On Tue, May 10, 2016 at 1:51 PM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Tue, May 10, 2016 at 08:09:53AM +0200, Hannes Reinecke wrote:
>> On 05/09/2016 09:54 PM, Bjorn Helgaas wrote:
>> > Hi Hannes,
>> >
>> > Geert's list of build regressions and improvements
>> > (http://lkml.kernel.org/r/1462782250-6231-1-git-send-email-geert@linux-m68k.org)
>> > shows these new warnings:
>> >
>> >   drivers/pci/access.c: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int' [-Wformat=]:  => 318:8
>> >   drivers/pci/access.c: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'unsigned int' [-Wformat=]:  => 340:6
>> >
>> > which I think are due to 104daa71b396 ("PCI: Determine actual VPD size on
>> > first access").
>> >
>> > Would you mind fixing those up and sending me a patch?  These were in
>> > the v4.6-rc1 regressions email, and I should have noticed then, but I
>> > didn't.
>> >
>> This is curious.
>> The code has this:
>>
>> size_t off = 0;
>>
>> ...
>>
>> dev_warn(&dev->dev,
>>       "invalid large VPD tag %02x size at offset %zu",
>>       tag, off + 1);
>>
>> Which, as per my reading, suggests that the last argument to
>> dev_warn() is of type size_t.
>>
>> Which tree has generated the above warning?
>
> Yeah, it wasn't obvious to me how this would happen either.  From
> Geert's original email, I think the tree is v4.6-rc7, i.e.,
> 44549e8f5eea4e0a41b487b63e616cb089922b99.
>
> Geert, can you tell which config generated this warning?

It was seen with v4.6-rc7/microblaze/nommu_defconfig only.

As I agree the type of the last parameter is correct, it's probably a
compiler issue.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds