linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-pci@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: Build warning regression (104daa71b396 ("PCI: Determine actual VPD size on first access"))
Date: Tue, 10 May 2016 06:51:03 -0500	[thread overview]
Message-ID: <20160510115103.GB29582@localhost> (raw)
In-Reply-To: <57317B31.8030203@suse.de>

[+cc Geert]

On Tue, May 10, 2016 at 08:09:53AM +0200, Hannes Reinecke wrote:
> On 05/09/2016 09:54 PM, Bjorn Helgaas wrote:
> > Hi Hannes,
> > 
> > Geert's list of build regressions and improvements
> > (http://lkml.kernel.org/r/1462782250-6231-1-git-send-email-geert@linux-m68k.org)
> > shows these new warnings:
> > 
> >   drivers/pci/access.c: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int' [-Wformat=]:  => 318:8
> >   drivers/pci/access.c: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'unsigned int' [-Wformat=]:  => 340:6
> > 
> > which I think are due to 104daa71b396 ("PCI: Determine actual VPD size on
> > first access").
> > 
> > Would you mind fixing those up and sending me a patch?  These were in
> > the v4.6-rc1 regressions email, and I should have noticed then, but I
> > didn't.
> > 
> This is curious.
> The code has this:
> 
> size_t off = 0;
> 
> ...
> 
> dev_warn(&dev->dev,
> 	"invalid large VPD tag %02x size at offset %zu",
> 	tag, off + 1);
> 
> Which, as per my reading, suggests that the last argument to
> dev_warn() is of type size_t.
> 
> Which tree has generated the above warning?

Yeah, it wasn't obvious to me how this would happen either.  From
Geert's original email, I think the tree is v4.6-rc7, i.e.,
44549e8f5eea4e0a41b487b63e616cb089922b99.

Geert, can you tell which config generated this warning?

  reply	other threads:[~2016-05-10 11:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09 19:54 Build warning regression (104daa71b396 ("PCI: Determine actual VPD size on first access")) Bjorn Helgaas
2016-05-10  6:09 ` Hannes Reinecke
2016-05-10 11:51   ` Bjorn Helgaas [this message]
2016-05-10 11:56     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160510115103.GB29582@localhost \
    --to=helgaas@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=hare@suse.de \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).