From: Lukas Wunner <lukas@wunner.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Qipeng Zha <qipeng.zha@intel.com>, Qi Zheng <qi.zheng@intel.com>,
Dave Airlie <airlied@gmail.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andreas Noever <andreas.noever@gmail.com>,
Peter Wu <peter@lekensteyn.nl>,
Valdis Kletnieks <Valdis.Kletnieks@vt.edu>,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v6 0/5] PCI: Add support for suspending (including runtime) of PCIe ports
Date: Sun, 5 Jun 2016 01:27:18 +0200 [thread overview]
Message-ID: <20160604232718.GA17088@wunner.de> (raw)
In-Reply-To: <1464855435-32960-1-git-send-email-mika.westerberg@linux.intel.com>
On Thu, Jun 02, 2016 at 11:17:10AM +0300, Mika Westerberg wrote:
> Bjorn, if you are fine with these patches, it would be nice to get these to
> linux-next for better testing coverage.
>
> Changes to v5:
>
> - Add patch "PCI: Power on bridges before scanning new devices" to make
> sure rescanning using sysfs still works.
>
> - Change patch "ACPI / hotplug / PCI: Runtime resume bridge before
> rescan" to runtime resume in acpiphp_check_bridge() instead of
> hotplug_event().
>
> - Change runtime PM autosuspend delay from 10ms to 100ms.
>
> - Call pm_runtime_mark_last_busy() to make sure we do not runtime suspend
> the port immediately.
I've applied v6 of this series to my local tree and tested it with
my Thunderbolt runtime pm patches. Everything seems to still work
fine, so my Tested-by is upheld.
I've also compared this version with the previous one in my tree and
reviewed the changes. I only found a punctuation and spacing change
that Bjorn had made and that isn't included in the commit message of
patch [4/5]:
< hotplug event such as BUS_CHECK, we need to make sure it is resumed before
< devices below the bridge are re-scanned. Otherwise the devices behind the
---
> hotplug event, such as BUS_CHECK we need to make sure it is resumed before
> devices below the bridge are re-scanned. Otherwise the devices behind the
And this line in the commit message of patch [5/5] suddenly has > 72
chars now:
> Add back runtime PM support for PCIe ports that was removed in
> commit fe9a743a2601 ("PCI/PM: Drop unused runtime PM support code for PCIe
Thanks,
Lukas
next prev parent reply other threads:[~2016-06-04 23:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 8:17 [PATCH v6 0/5] PCI: Add support for suspending (including runtime) of PCIe ports Mika Westerberg
2016-06-02 8:17 ` [PATCH v6 1/5] PCI: Don't clear d3cold_allowed for " Mika Westerberg
2016-06-02 8:17 ` [PATCH v6 2/5] PCI: Put PCIe ports into D3 during suspend Mika Westerberg
2016-06-02 8:17 ` [PATCH v6 3/5] PCI: Power on bridges before scanning new devices Mika Westerberg
2016-06-02 12:26 ` Rafael J. Wysocki
2016-06-02 8:17 ` [PATCH v6 4/5] ACPI / hotplug / PCI: Runtime resume bridge before rescan Mika Westerberg
2016-06-02 12:27 ` Rafael J. Wysocki
2016-06-02 8:17 ` [PATCH v6 5/5] PCI: Add runtime PM support for PCIe ports Mika Westerberg
2016-06-04 23:27 ` Lukas Wunner [this message]
2016-06-06 9:43 ` [PATCH v6 0/5] PCI: Add support for suspending (including runtime) of " Mika Westerberg
2016-06-13 20:05 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160604232718.GA17088@wunner.de \
--to=lukas@wunner.de \
--cc=Valdis.Kletnieks@vt.edu \
--cc=airlied@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=peter@lekensteyn.nl \
--cc=qi.zheng@intel.com \
--cc=qipeng.zha@intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).