From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:16345 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753383AbcFHU46 (ORCPT ); Wed, 8 Jun 2016 16:56:58 -0400 Date: Wed, 8 Jun 2016 14:56:56 -0600 From: Jon Derrick To: "Busch, Keith" Cc: "linux-pci@vger.kernel.org" , Bjorn Helgaas Subject: Re: [PATCHv2] x86/vmd: Initialize list item in irq disable Message-ID: <20160608205656.GA3568@localhost.localdomain> References: <1463505738-30666-1-git-send-email-keith.busch@intel.com> <20160517185101.GA1975@localhost.localdomain> <8D943B239464E04C9184454D8B3F5CFF0AD53672@ORSMSX101.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <8D943B239464E04C9184454D8B3F5CFF0AD53672@ORSMSX101.amr.corp.intel.com> Sender: linux-pci-owner@vger.kernel.org List-ID: Hi Bjorn, Let me know if there's anything else needing to be done to get this set in. Thanks, Jon On Wed, Jun 01, 2016 at 03:10:30PM -0600, Derrick, Jonathan wrote: > Hi Bjorn, > > Any plans to get this set in? > > Thanks, > J > > -----Original Message----- > From: linux-pci-owner@vger.kernel.org [mailto:linux-pci-owner@vger.kernel.org] On Behalf Of Jon Derrick > Sent: Tuesday, May 17, 2016 12:51 PM > To: Busch, Keith > Cc: linux-pci@vger.kernel.org; Bjorn Helgaas > Subject: Re: [PATCHv2] x86/vmd: Initialize list item in irq disable > > Acked-by Jon Derrick: > > On Tue, May 17, 2016 at 11:22:18AM -0600, Keith Busch wrote: > > Multiple calls to disable an IRQ would have caused the driver to > > dereference a poisoned list item. This re-initializes the list to > > allow multiple requests to disable the irq. > > > > Signed-off-by: Keith Busch > > --- > > v1 -> v2: > > Used the patch with the correct macro > > > > arch/x86/pci/vmd.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/x86/pci/vmd.c b/arch/x86/pci/vmd.c index > > b1662bf..3519a15 100644 > > --- a/arch/x86/pci/vmd.c > > +++ b/arch/x86/pci/vmd.c > > @@ -135,6 +135,7 @@ static void vmd_irq_disable(struct irq_data *data) > > > > raw_spin_lock(&list_lock); > > list_del_rcu(&vmdirq->node); > > + INIT_LIST_HEAD_RCU(&vmdirq->node); > > raw_spin_unlock(&list_lock); > > } > > > > -- > > 2.7.2 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html