From: Bjorn Helgaas <helgaas@kernel.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/ASPM: Remove redundant check of pcie_set_clkpm
Date: Fri, 10 Jun 2016 19:09:04 -0500 [thread overview]
Message-ID: <20160611000904.GF16462@localhost> (raw)
In-Reply-To: <1464082330-22437-1-git-send-email-shawn.lin@rock-chips.com>
On Tue, May 24, 2016 at 05:32:10PM +0800, Shawn Lin wrote:
> Without supporting clock PM capable, if we want to disable
> clkpm, we don't need this extra check as it already be zero for
> the enable argument. And it's the same for enabling clkpm here.
> So let's remove this check.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Applied to pci/aspm for v4.8, thanks, Shawn.
> ---
>
> drivers/pci/pcie/aspm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index 2dfe7fd..0ec649d 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -139,7 +139,7 @@ static void pcie_set_clkpm_nocheck(struct pcie_link_state *link, int enable)
> static void pcie_set_clkpm(struct pcie_link_state *link, int enable)
> {
> /* Don't enable Clock PM if the link is not Clock PM capable */
> - if (!link->clkpm_capable && enable)
> + if (!link->clkpm_capable)
> enable = 0;
> /* Need nothing if the specified equals to current state */
> if (link->clkpm_enabled == enable)
> --
> 2.3.7
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-06-11 0:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 9:32 [PATCH] PCI/ASPM: Remove redundant check of pcie_set_clkpm Shawn Lin
2016-06-11 0:09 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160611000904.GF16462@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).