From: Alex Williamson <alex.williamson@redhat.com>
To: Ilya Lesokhin <ilyal@mellanox.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"Noa Osherovich" <noaos@mellanox.com>,
Haggai Eran <haggaie@mellanox.com>,
"Or Gerlitz" <ogerlitz@mellanox.com>,
Liran Liss <liranl@mellanox.com>
Subject: Re: [PATCH 1/4] VFIO: Probe new devices in a live VFIO group with the VFIO driver
Date: Mon, 13 Jun 2016 10:02:48 -0600 [thread overview]
Message-ID: <20160613100248.354e4e7f@ul30vt.home> (raw)
In-Reply-To: <VI1PR0501MB1968DDC0D3A32A946B72C7D7D4530@VI1PR0501MB1968.eurprd05.prod.outlook.com>
On Mon, 13 Jun 2016 06:33:53 +0000
Ilya Lesokhin <ilyal@mellanox.com> wrote:
> > -----Original Message-----
> > From: Alex Williamson [mailto:alex.williamson@redhat.com]
> > Sent: Friday, June 10, 2016 1:22 AM
> > To: Ilya Lesokhin <ilyal@mellanox.com>
> > Cc: kvm@vger.kernel.org; linux-pci@vger.kernel.org; bhelgaas@google.com;
> > Noa Osherovich <noaos@mellanox.com>; Haggai Eran
> > <haggaie@mellanox.com>; Or Gerlitz <ogerlitz@mellanox.com>; Liran Liss
> > <liranl@mellanox.com>
> > Subject: Re: [PATCH 1/4] VFIO: Probe new devices in a live VFIO group with
> > the VFIO driver
> ...
> > > + pdev = to_pci_dev(dev);
> > > + if (pdev->driver_override)
> > > + kfree(pdev->driver_override);
> > > + pdev->driver_override = kstrdup("vfio-pci", GFP_KERNEL);
> >
> > kstrdup can fail. Probably want to issue a about capturing
> > the device as well. Thanks,
> >
>
> Any recommendation as to what I should do in case kstrdup fails?
> Fallback to the existing warning ("device added to a live group") ?
Probably so. Thanks,
Alex
next prev parent reply other threads:[~2016-06-13 16:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 12:09 [PATCH 0/4] VFIO SR-IOV support Ilya Lesokhin
2016-06-09 12:09 ` [PATCH 1/4] VFIO: Probe new devices in a live VFIO group with the VFIO driver Ilya Lesokhin
2016-06-09 22:21 ` Alex Williamson
2016-06-13 6:33 ` Ilya Lesokhin
2016-06-13 16:02 ` Alex Williamson [this message]
2016-06-09 12:09 ` [PATCH 2/4] IOMMU: Force the VFs of an untrusted PF device to be in the PFs IOMMU group Ilya Lesokhin
2016-06-09 12:56 ` kbuild test robot
2016-06-09 15:21 ` kbuild test robot
2016-06-09 22:21 ` Alex Williamson
2016-06-13 7:08 ` Ilya Lesokhin
2016-06-13 16:00 ` Alex Williamson
2016-06-16 12:46 ` Ilya Lesokhin
2016-06-09 12:09 ` [PATCH 3/4] PCI: Expose iov_set_numvfs and iov_resource_size for modules Ilya Lesokhin
2016-06-09 12:27 ` kbuild test robot
2016-06-09 12:09 ` [PATCH 4/4] VFIO: Add support for SR-IOV extended capablity Ilya Lesokhin
2016-06-09 12:09 ` [PATCH 4/4] VFIO: Add support for SRIOV " Ilya Lesokhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613100248.354e4e7f@ul30vt.home \
--to=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=haggaie@mellanox.com \
--cc=ilyal@mellanox.com \
--cc=kvm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liranl@mellanox.com \
--cc=noaos@mellanox.com \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).