From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 1/2] pci: Error disabling SR-IOV if in VFs assigned
Date: Mon, 13 Jun 2016 17:28:10 -0400 [thread overview]
Message-ID: <20160613212810.GG12766@localhost.localdomain> (raw)
In-Reply-To: <20160613211411.GC18747@localhost>
On Mon, Jun 13, 2016 at 04:14:11PM -0500, Bjorn Helgaas wrote:
> On Tue, May 17, 2016 at 03:39:58PM -0600, Keith Busch wrote:
> > Every sriov capable driver has to check if any guest is using a virtual
> > function prior to disabling, so let's make it common code.
> >
> > Signed-off-by: Keith Busch <keith.busch@intel.com>
>
> If I understand the discussion correctly, this is still racy but
> nobody objects to adding this until we have a better, non-racy
> solution.
My understanding as well: there's a potential race, but no different
than what exists with today.
> However, you added this in common code and took advantage of it in
> nvme. Good so far. But we have about a dozen other drivers that call
> pci_vfs_assigned(). I assume some of those places could be changed so
> they take advantage of this check in the core instead?
> Can we do that at the same time? If we add good new stuff and only
> use it one place, there's not as much overall goodness as there would
> be if we updated everybody to do it similarly.
Sounds good, I'll send a series taking advantage of this for all the
other PF drivers duplicating this check in their sriov_configure.
next prev parent reply other threads:[~2016-06-13 21:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 21:39 [PATCH 1/2] pci: Error disabling SR-IOV if in VFs assigned Keith Busch
2016-05-17 21:39 ` [PATCH 2/2] nvme/pci: Enable SR-IOV capabilities Keith Busch
2016-05-23 10:52 ` Christoph Hellwig
2016-05-23 17:06 ` Bjorn Helgaas
2016-05-23 17:09 ` Christoph Hellwig
2016-05-23 17:21 ` Keith Busch
2016-05-23 21:51 ` Bjorn Helgaas
2016-05-17 22:08 ` [PATCH 1/2] pci: Error disabling SR-IOV if in VFs assigned Alex Williamson
2016-05-23 10:55 ` Christoph Hellwig
2016-05-23 15:07 ` Alex Williamson
2016-05-23 15:10 ` Christoph Hellwig
2016-06-13 21:14 ` Bjorn Helgaas
2016-06-13 21:28 ` Keith Busch [this message]
2016-06-13 21:57 ` Keith Busch
2016-06-13 22:26 ` Bjorn Helgaas
2016-06-13 22:35 ` Keith Busch
2016-06-15 10:26 ` Christoph Hellwig
2016-06-15 15:38 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613212810.GG12766@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).