From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Mon, 13 Jun 2016 17:57:37 -0400 From: Keith Busch To: Bjorn Helgaas Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Jens Axboe , linux-nvme@lists.infradead.org, Christoph Hellwig Subject: Re: [PATCH 1/2] pci: Error disabling SR-IOV if in VFs assigned Message-ID: <20160613215736.GH12766@localhost.localdomain> References: <1463521199-16604-1-git-send-email-keith.busch@intel.com> <20160613211411.GC18747@localhost> <20160613212810.GG12766@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20160613212810.GG12766@localhost.localdomain> List-ID: On Mon, Jun 13, 2016 at 05:28:10PM -0400, Keith Busch wrote: > On Mon, Jun 13, 2016 at 04:14:11PM -0500, Bjorn Helgaas wrote: > > Can we do that at the same time? If we add good new stuff and only > > use it one place, there's not as much overall goodness as there would > > be if we updated everybody to do it similarly. > > Sounds good, I'll send a series taking advantage of this for all the > other PF drivers duplicating this check in their sriov_configure. Heh, I thought "no big deal", thinking all use was similar to NVMe's. However, most network drivers have multiple paths to sriov configuration, or have other requirements to changing the live count! There's only two drivers I find that can immediately use the simplification safely. I'll send those updates to just those ones.