linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Peter Wu <peter@lekensteyn.nl>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: export pci_bridge_d3_possible
Date: Fri, 8 Jul 2016 11:25:03 +0300	[thread overview]
Message-ID: <20160708082503.GY23527@lahna.fi.intel.com> (raw)
In-Reply-To: <20160707235448.2622-1-peter@lekensteyn.nl>

On Fri, Jul 08, 2016 at 01:54:48AM +0200, Peter Wu wrote:
> Allow the nouveau driver to find out whether the bridge can put itself
> in the D3cold state or whether it should use a specific DSM method to
> achieve the same result.
> 
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Peter Wu <peter@lekensteyn.nl>
> ---
> Since it is not yet merged in Linus tree, maybe the patch in pci/pm can be
> amended? This is the follow-up patch I had in mind for nouveau:
> 
>     --- a/drivers/gpu/drm/nouveau/nouveau_acpi.c
>     +++ b/drivers/gpu/drm/nouveau/nouveau_acpi.c
>     @@ -223,6 +223,9 @@ static bool nouveau_pr3_present(struct pci_dev *pdev)
>      	if (!parent_pdev)
>      		return false;
>      
>     +	if (!pci_bridge_d3_possible(parent_pdev))
>     +		return false;
>     +

Why not check bridge_d3 directly?

	if (!parent_dev->bridge_d3)
		return false;

  reply	other threads:[~2016-07-08  8:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07 23:54 [PATCH] PCI: export pci_bridge_d3_possible Peter Wu
2016-07-08  8:25 ` Mika Westerberg [this message]
2016-07-08  8:45   ` Peter Wu
2016-07-08  9:24     ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160708082503.GY23527@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=peter@lekensteyn.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).