linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: linux-pci@vger.kernel.org, vfio-users@redhat.com, tglx@linutronix.de
Subject: Re: The same IOMMU group for igb and its igbvf siblings
Date: Sat, 9 Jul 2016 22:01:51 +0200	[thread overview]
Message-ID: <20160709200151.GA27170@breakpoint.cc> (raw)
In-Reply-To: <20160709134403.0feb2150@t450s.home>

On 2016-07-09 13:44:03 [-0600], Alex Williamson wrote:
> The root port device IDs translate to a Skylake platform, which is a
> "client" processor.  Core-i3/5/7 and even Xeon E3 fit into this

It is an E3-1230 v5

> category and they do not support ACS on the processor root ports.  This
> groups everything downstream of those root ports together and even
> binds together separate sub-hierarchies when the root ports are joined
> in a multifunction slot.  Without ACS we cannot guarantee that
> peer-to-peer DMA does not occur through redirection prior to IOMMU
> translation.

So it is not a missing BIOS knob but a missing CPU feature.

> The easiest solution is to move the card to one of the PCH sourced root
> ports (ie. downstream of root ports at 00:1c.*).  As of kernel v4.7-rc1
> we have quirks for the Sunrise Point PCH to work around the botched
> implementation of ACS found in this chipset.  Pretty much all Intel
> client processors have the same story, no ACS in the processor root
> ports, quirks to enable ACS in the PCH root ports.  Xeon E5 and higher
> as well as "High End Desktop Processors" (based on E5) support ACS
> correctly (though the PCH root ports need and already have quirks for
> ACS).

bah. Not sure if another slot is possible / available but thanks for the
hint.

> There exists a non-upstream patch to override ACS, which does nothing
> to solve the isolation problem, it just allows you to gamble with data
> integrity, which is why it really has no place upstream.  The IGB
> devices you note in pci_dev_acs_enabled are quirks for the IGB PFs.
> Intel has confirmed that there is isolation between the PFs, so when
> installed into topology that does have ACS support, this allows the PFs
> to be put into separate groups.  Since the point at which your system
> lacks isolation is upstream of the PFs, this doesn't help you.  Thanks,

Thank you for the explanation.

> Alex

Sebastian

      reply	other threads:[~2016-07-09 20:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-09 19:16 The same IOMMU group for igb and its igbvf siblings Sebastian Andrzej Siewior
2016-07-09 19:44 ` Alex Williamson
2016-07-09 20:01   ` Sebastian Andrzej Siewior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160709200151.GA27170@breakpoint.cc \
    --to=sebastian@breakpoint.cc \
    --cc=alex.williamson@redhat.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vfio-users@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).