From: Christoph Hellwig <hch@lst.de>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
tglx@linutronix.de, axboe@fb.com, linux-block@vger.kernel.org,
linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/13] nvme: switch to use pci_alloc_irq_vectors
Date: Sun, 10 Jul 2016 05:59:26 +0200 [thread overview]
Message-ID: <20160710035926.GD15720@lst.de> (raw)
In-Reply-To: <20160707193019.GA8802@dhcp-27-118.brq.redhat.com>
On Thu, Jul 07, 2016 at 09:30:19PM +0200, Alexander Gordeev wrote:
> On Mon, Jul 04, 2016 at 05:39:33PM +0900, Christoph Hellwig wrote:
> > @@ -1575,6 +1546,7 @@ static int nvme_dev_add(struct nvme_dev *dev)
> > dev->tagset.cmd_size = nvme_cmd_size(dev);
> > dev->tagset.flags = BLK_MQ_F_SHOULD_MERGE;
> > dev->tagset.driver_data = dev;
> > + dev->tagset.affinity_mask = to_pci_dev(dev->dev)->irq_affinity;
> >
> > if (blk_mq_alloc_tag_set(&dev->tagset))
> > return 0;
>
> Are there any post-init uses of blk_mq_tag_set::affinity_mask other than
> calling to blk_mq_alloc_tag_set()? If no, blk_mq_tag_set::affinity_mask
> is redundant, since the mask could be passed as a parameter.
We'll have to look at it in the block code when reinitializing rebuilding
the queue topology. This isn't currently done, but we'll need it rather
soon.
next prev parent reply other threads:[~2016-07-10 3:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 8:39 automatic interrupt affinity for MSI/MSI-X capable devices V3 Christoph Hellwig
2016-07-04 8:39 ` [PATCH 01/13] irq/msi: Remove unused MSI_FLAG_IDENTITY_MAP Christoph Hellwig
2016-07-04 8:39 ` [PATCH 02/13] irq: Introduce IRQD_AFFINITY_MANAGED flag Christoph Hellwig
2016-07-04 8:39 ` [PATCH 03/13] irq: Add affinity hint to irq allocation Christoph Hellwig
[not found] ` <1468875386-31662-1-git-send-email-vincent.stehle@laposte.net>
2016-07-19 3:56 ` [PATCH next] genirq: fix missing irq allocation affinity hint Christoph Hellwig
2016-07-19 12:03 ` Thomas Gleixner
2016-07-04 8:39 ` [PATCH 04/13] irq: Use affinity hint in irqdesc allocation Christoph Hellwig
2016-07-04 8:39 ` [PATCH 05/13] irq/msi: Make use of affinity aware allocations Christoph Hellwig
2016-07-04 8:39 ` [PATCH 06/13] irq: add a helper spread an affinity mask for MSI/MSI-X vectors Christoph Hellwig
2016-07-04 8:39 ` [PATCH 07/13] pci: Provide sensible irq vector alloc/free routines Christoph Hellwig
2016-07-06 8:05 ` Alexander Gordeev
2016-07-10 3:47 ` Christoph Hellwig
2016-07-11 10:43 ` Alexander Gordeev
2016-07-12 9:13 ` Christoph Hellwig
2016-07-12 12:46 ` Alexander Gordeev
2016-07-04 8:39 ` [PATCH 08/13] pci: spread interrupt vectors in pci_alloc_irq_vectors Christoph Hellwig
2016-07-07 11:05 ` Alexander Gordeev
2016-07-10 3:57 ` Christoph Hellwig
2016-07-12 6:49 ` Alexander Gordeev
2016-07-04 8:39 ` [PATCH 09/13] blk-mq: don't redistribute hardware queues on a CPU hotplug event Christoph Hellwig
2016-07-04 8:39 ` [PATCH 10/13] blk-mq: only allocate a single mq_map per tag_set Christoph Hellwig
2016-07-04 8:39 ` [PATCH 11/13] blk-mq: allow the driver to pass in an affinity mask Christoph Hellwig
2016-07-04 8:39 ` [PATCH 12/13] nvme: switch to use pci_alloc_irq_vectors Christoph Hellwig
2016-07-07 19:30 ` Alexander Gordeev
2016-07-10 3:59 ` Christoph Hellwig [this message]
2016-07-04 8:39 ` [PATCH 13/13] nvme: remove the post_scan callout Christoph Hellwig
2016-07-04 10:30 ` automatic interrupt affinity for MSI/MSI-X capable devices V3 Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2016-06-14 19:58 automatic interrupt affinity for MSI/MSI-X capable devices V2 Christoph Hellwig
2016-06-14 19:59 ` [PATCH 12/13] nvme: switch to use pci_alloc_irq_vectors Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160710035926.GD15720@lst.de \
--to=hch@lst.de \
--cc=agordeev@redhat.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).