linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Utkin <andrey_utkin@fastmail.com>
To: Andrey Utkin <andrey.utkin@corp.bluecherry.net>
Cc: "Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Bluecherry Maintainers" <maintainers@bluecherrydvr.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Kalle Valo" <kvalo@codeaurora.org>,
	"Joe Perches" <joe@perches.com>, "Jiri Slaby" <jslaby@suse.com>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Kozlov Sergey" <serjk@netup.ru>,
	"Ezequiel Garcia" <ezequiel@vanguardiasur.com.ar>,
	"Hans Verkuil" <hans.verkuil@cisco.com>,
	"Krzysztof Hałasa" <khalasa@piap.pl>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-pci@vger.kernel.org,
	kernel-mentors@selenic.com
Subject: Re: [PATCH v4] [media] pci: Add tw5864 driver - fixed few style nits, going to resubmit soon
Date: Wed, 13 Jul 2016 05:05:04 +0300	[thread overview]
Message-ID: <20160713020504.GH5934@zver> (raw)
In-Reply-To: <20160711151714.5452-1-andrey.utkin@corp.bluecherry.net>

Found and fixed few very minor coding style nits, will resubmit in few days,
now still waiting for comments to v4.

https://github.com/bluecherrydvr/linux/commits/tw5864

commit 31f7c98a144cb3fb8a94662f002d9b6142d1f390
Author: Andrey Utkin <andrey.utkin@corp.bluecherry.net>
Date:   Wed Jul 13 05:00:28 2016 +0300

    Fix checkpatch --strict issue
    
     CHECK: Alignment should match open parenthesis
     #3599: FILE: drivers/media/pci/tw5864/tw5864-video.c:539:
     +static int tw5864_fmt_vid_cap(struct file *file, void *priv,
     +                               struct v4l2_format *f)

commit 11a09a1048af597ecf374507b08c809eed91b86d
Author: Andrey Utkin <andrey.utkin@corp.bluecherry.net>
Date:   Wed Jul 13 04:59:34 2016 +0300

    Fix checkpatch --strict issue
    
     CHECK: Please don't use multiple blank lines
     #3244: FILE: drivers/media/pci/tw5864/tw5864-video.c:184:

commit 861b2ba8593db7abe89291a4ba85976519783f4a
Author: Andrey Utkin <andrey.utkin@corp.bluecherry.net>
Date:   Wed Jul 13 04:58:37 2016 +0300

    Fix checkpatch --strict issue
    
     CHECK: No space is necessary after a cast
     #3053: FILE: drivers/media/pci/tw5864/tw5864-util.c:36:
     +       return (u8) tw_readl(TW5864_IND_DATA);

  parent reply	other threads:[~2016-07-13  2:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11 15:17 [PATCH v4] [media] pci: Add tw5864 driver Andrey Utkin
2016-07-11 16:40 ` Joe Perches
2016-07-13  1:56   ` Andrey Utkin
2016-07-13  2:05 ` Andrey Utkin [this message]
2016-07-13  7:05   ` [PATCH v4] [media] pci: Add tw5864 driver - fixed few style nits, going to resubmit soon Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160713020504.GH5934@zver \
    --to=andrey_utkin@fastmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrey.utkin@corp.bluecherry.net \
    --cc=bhelgaas@google.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hans.verkuil@cisco.com \
    --cc=joe@perches.com \
    --cc=jslaby@suse.com \
    --cc=kernel-mentors@selenic.com \
    --cc=khalasa@piap.pl \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=maintainers@bluecherrydvr.com \
    --cc=mchehab@osg.samsung.com \
    --cc=serjk@netup.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).