From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: <bhelgaas@google.com>, <michal.simek@xilinx.com>,
<bharat.kumar.gogada@xilinx.com>, <rgummal@xilinx.com>,
<arnd@arndb.de>, <jiang.liu@linux.intel.com>,
<grygorii.strashko@ti.com>, <russell.joyce@york.ac.uk>,
<lorenzo.pieralisi@arm.com>, <linux-pci@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] PCI: xilinx: Fix return value in case of error
Date: Thu, 14 Jul 2016 06:12:49 -0700 [thread overview]
Message-ID: <20160714131249.GJ3847@xsjsorenbubuntu> (raw)
In-Reply-To: <1468491046-1427-1-git-send-email-christophe.jaillet@wanadoo.fr>
On Thu, 2016-07-14 at 12:10:46 +0200, Christophe JAILLET wrote:
> In function 'xilinx_pcie_init_irq_domain', the pattern used to check and
> return error is:
>
> if (!var) {
> dev_err(...);
> return PTR_ERR(var);
> }
>
> So the returned value in case of error is always 0, which means 'success'.
> Change it to return -ENODEV instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>
Sören
next prev parent reply other threads:[~2016-07-14 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 10:10 [PATCH] PCI: xilinx: Fix return value in case of error Christophe JAILLET
2016-07-14 13:12 ` Sören Brinkmann [this message]
2016-07-25 17:29 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714131249.GJ3847@xsjsorenbubuntu \
--to=soren.brinkmann@xilinx.com \
--cc=arnd@arndb.de \
--cc=bharat.kumar.gogada@xilinx.com \
--cc=bhelgaas@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=grygorii.strashko@ti.com \
--cc=jiang.liu@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=michal.simek@xilinx.com \
--cc=rgummal@xilinx.com \
--cc=russell.joyce@york.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox