From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Jon Derrick <jonathan.derrick@intel.com>
Subject: Re: [PATCH 1/2] vmd: Fix infinite loop executing irq's
Date: Fri, 5 Aug 2016 17:02:15 -0400 [thread overview]
Message-ID: <20160805210215.GB12688@localhost.localdomain> (raw)
In-Reply-To: <20160805170302.GA432@localhost>
On Fri, Aug 05, 2016 at 12:03:02PM -0500, Bjorn Helgaas wrote:
> It doesn't seem quite right to test for LIST_POISON2. It seems like a
> little too much knowledge of list internals. There are no other
> similar tests in the kernel. Surely this isn't the only case where we
> need to remove from a list that another thread might be traversing. I
> would look for other similar situations and copy the way they handle
> it.
Yeah, I agree that's abusing internal knowledge of the API. We can
track this state another way. Will fix and resend.
> I think I saw a Fixes: tag later, so I assume you'll pick that up for
> v2. Should this also be tagged for stable? Are there any bug reports
> we should reference?
I'll add the fixes in the v2. This bug was reported only on internal
Intel bug tracking, but I can still add a "Reported-by" and "Tested-by"
tags. And no need for a stable since the bug was introduced in 4.8
merge window.
prev parent reply other threads:[~2016-08-05 21:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 22:09 [PATCH 1/2] vmd: Fix infinite loop executing irq's Keith Busch
2016-08-04 22:09 ` [PATCH 2/2] vmd: Synchronize with RCU freeing msi irq descs Keith Busch
2016-08-08 16:47 ` Jon Derrick
2016-08-29 16:07 ` Jon Derrick
2016-09-14 22:10 ` Bjorn Helgaas
2016-08-04 22:48 ` [PATCH 1/2] vmd: Fix infinite loop executing irq's Myron Stowe
2016-08-04 23:12 ` Derrick, Jonathan
2016-08-05 17:03 ` Bjorn Helgaas
2016-08-05 21:02 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805210215.GB12688@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox