From: Bjorn Helgaas <helgaas@kernel.org>
To: "Yong, Jonathan" <jonathan.yong@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/3] PCI: Precision Time Measurement support
Date: Mon, 15 Aug 2016 13:51:11 -0500 [thread overview]
Message-ID: <20160815185111.GC9790@localhost> (raw)
In-Reply-To: <578EBC81.3090601@intel.com>
On Wed, Jul 20, 2016 at 07:49:21AM +0800, Yong, Jonathan wrote:
> On 07/20/2016 05:19, Bjorn Helgaas wrote:
> > On Mon, Jun 13, 2016 at 02:05:26PM -0500, Bjorn Helgaas wrote:
> >> This is a slightly different proposal for the PTM support Jonathan
> >> proposed here:
> >>
> >> http://lkml.kernel.org/r/1462956446-27361-2-git-send-email-jonathan.yong@intel.com
> >>
> >> I split this into three pieces mostly for ease in reviewing. They
> >> could all be squashed:
> >>
> >> - Enable PTM in root ports and switches automatically at boot
> >> - Enable PTM in endpoints when requested by driver
> >> - Add clock granularity information
> >>
> >> I have some open questions about how PTM works on Root Complex
> >> Integrated Endpoints and whether we should enable it automatically
> >> even without a driver request. And I probably left out some details
> >> of the clock granularity computation, so treat this as more of an RFC
> >> than anything.
> >>
> >
> > Jonathan, any comments?
> >
>
> I don't have any new information on how to configure integrated endpoints.
>
> This line:
> ctrl = PCI_PTM_CTRL_ENABLE | PCI_PTM_CTRL_ROOT;
>
> should also set the responder capable bit (7.32.2):
> If PTM Root Capable is Set, this bit must be Set to 1b.
The PTM Responder Capable bit (bit 1 in Table 7-145) is a HwInit bit
in the PTM Capability register, so it's read-only from the kernel's
perspective.
The line you mention ("ctrl = PCI_PTM_CTRL_ENABLE | PCI_PTM_CTRL_ROOT")
is turning on bits in the PTM Control register, not the Capability
register.
Bjorn
next prev parent reply other threads:[~2016-08-15 18:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 19:05 [PATCH v6 0/3] PCI: Precision Time Measurement support Bjorn Helgaas
2016-06-13 19:05 ` [PATCH v6 1/3] PCI: Add Precision Time Measurement (PTM) support Bjorn Helgaas
2016-08-10 2:58 ` Yong, Jonathan
2016-08-15 18:59 ` Bjorn Helgaas
2016-08-16 8:04 ` Yong, Jonathan
2016-08-16 13:37 ` Bjorn Helgaas
2016-08-17 8:51 ` Yong, Jonathan
2016-08-22 17:01 ` Bjorn Helgaas
2016-08-23 0:13 ` Yong, Jonathan
2016-06-13 19:05 ` [PATCH v6 2/3] PCI: Add pci_enable_ptm() for drivers to enable PTM on endpoints Bjorn Helgaas
2016-06-13 19:05 ` [PATCH v6 3/3] PCI: Add PTM clock granularity information Bjorn Helgaas
2016-06-13 19:42 ` kbuild test robot
2016-07-19 21:19 ` [PATCH v6 0/3] PCI: Precision Time Measurement support Bjorn Helgaas
2016-07-19 23:49 ` Yong, Jonathan
2016-08-15 18:51 ` Bjorn Helgaas [this message]
2016-08-16 1:27 ` Yong, Jonathan
2016-08-23 21:42 ` Bjorn Helgaas
2016-08-24 1:09 ` Yong, Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815185111.GC9790@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jonathan.yong@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).