From: Christoph Hellwig <hch@infradead.org>
To: Ilya Lesokhin <ilyal@mellanox.com>
Cc: kvm@vger.kernel.org, linux-pci@vger.kernel.org,
bhelgaas@google.com, alex.williamson@redhat.com,
noaos@mellanox.com, haggaie@mellanox.com, ogerlitz@mellanox.com,
liranl@mellanox.com
Subject: Re: [PATCH V3 2/3] vfio/pci: Allow control SR-IOV through sysfs interface
Date: Thu, 18 Aug 2016 15:11:10 -0700 [thread overview]
Message-ID: <20160818221110.GB25395@infradead.org> (raw)
In-Reply-To: <1471505357-78110-3-git-send-email-ilyal@mellanox.com>
On Thu, Aug 18, 2016 at 10:29:16AM +0300, Ilya Lesokhin wrote:
> +static int vfio_pci_sriov_configure(struct pci_dev *pdev, int num_vfs)
> +{
> + if (!num_vfs) {
> + pci_disable_sriov(pdev);
> + return 0;
> + }
> +
> + return pci_enable_sriov_with_override(pdev,
> + num_vfs,
> + "vfio-pci");
> +}
I have to admit that I don't really like this API. Would it be
major burden for use case to just have a flag instead that disables
automatic driver attachments for VFs and requires manual binding
instead?
next prev parent reply other threads:[~2016-08-19 1:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 7:29 [PATCH V3 0/3] VFIO SRIOV support Ilya Lesokhin
2016-08-18 7:29 ` [PATCH V3 1/3] pci: Extend PCI IOV API Ilya Lesokhin
2016-08-18 22:09 ` Christoph Hellwig
2016-08-22 18:51 ` kbuild test robot
2016-08-18 7:29 ` [PATCH V3 2/3] vfio/pci: Allow control SR-IOV through sysfs interface Ilya Lesokhin
2016-08-18 22:11 ` Christoph Hellwig [this message]
2016-08-18 7:29 ` [PATCH V3 3/3] vfio/pci: Add support for SR-IOV extended capablity Ilya Lesokhin
2016-08-18 20:32 ` Alex Williamson
2016-08-22 6:48 ` kbuild test robot
2017-03-08 7:29 ` [PATCH V3 0/3] VFIO SRIOV support Jike Song
2017-03-09 6:24 ` Ilya Lesokhin
2017-03-09 6:29 ` You, Lizhen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818221110.GB25395@infradead.org \
--to=hch@infradead.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=haggaie@mellanox.com \
--cc=ilyal@mellanox.com \
--cc=kvm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liranl@mellanox.com \
--cc=noaos@mellanox.com \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).