From: Bjorn Helgaas <helgaas@kernel.org>
To: Keith Busch <keith.busch@intel.com>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Wei Zhang <wzhang@fb.com>
Subject: Re: [PATCH] pciehp: Clear attention LED on device add
Date: Mon, 22 Aug 2016 11:59:12 -0500 [thread overview]
Message-ID: <20160822165912.GD18628@localhost> (raw)
In-Reply-To: <1470266985-28906-1-git-send-email-keith.busch@intel.com>
On Wed, Aug 03, 2016 at 05:29:45PM -0600, Keith Busch wrote:
> This patch clears the LED attention status after a successful device
> add. It is possible the attention LED was on from a previous power fault
> or link failure, and a subsequent successful device inserted in the slot
> should clear it.
>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
Applied to pci/hotplug for v4.9, thanks, Keith!
> ---
> drivers/pci/hotplug/pciehp_ctrl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c
> index 880978b..7ea3e61 100644
> --- a/drivers/pci/hotplug/pciehp_ctrl.c
> +++ b/drivers/pci/hotplug/pciehp_ctrl.c
> @@ -120,6 +120,7 @@ static int board_added(struct slot *p_slot)
> }
>
> pciehp_green_led_on(p_slot);
> + pciehp_set_attention_status(p_slot, 0);
> return 0;
>
> err_exit:
> --
> 2.7.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-08-22 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 23:29 [PATCH] pciehp: Clear attention LED on device add Keith Busch
2016-08-22 16:59 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822165912.GD18628@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).