From: Bjorn Helgaas <helgaas@kernel.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Pratyush Anand <pratyush.anand@gmail.com>,
Joao Pinto <jpinto@synopsys.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH -next] PCI: designware-plat: Remove redundant return value check of platform_get_resource()
Date: Mon, 22 Aug 2016 14:23:47 -0500 [thread overview]
Message-ID: <20160822192346.GI18628@localhost> (raw)
In-Reply-To: <1469722494-14701-1-git-send-email-weiyj.lk@gmail.com>
On Thu, Jul 28, 2016 at 04:14:54PM +0000, Wei Yongjun wrote:
> Remove unneeded error handling on the result of a call
> to platform_get_resource() when the value is passed to
> devm_ioremap_resource().
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Applied to pci/host-designware for v4.9, thanks!
I'll also post a similar patch for altera, and a sort-of-similar one
for rcar.
> ---
> drivers/pci/host/pcie-designware-plat.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-designware-plat.c b/drivers/pci/host/pcie-designware-plat.c
> index c8079dc..17da005 100644
> --- a/drivers/pci/host/pcie-designware-plat.c
> +++ b/drivers/pci/host/pcie-designware-plat.c
> @@ -100,9 +100,6 @@ static int dw_plat_pcie_probe(struct platform_device *pdev)
> pp->dev = &pdev->dev;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res)
> - return -ENODEV;
> -
> dw_plat_pcie->mem_base = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(dw_plat_pcie->mem_base))
> return PTR_ERR(dw_plat_pcie->mem_base);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-08-22 19:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 16:14 [PATCH -next] PCI: designware-plat: Remove redundant return value check of platform_get_resource() Wei Yongjun
2016-08-22 19:23 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822192346.GI18628@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=jpinto@synopsys.com \
--cc=linux-pci@vger.kernel.org \
--cc=pratyush.anand@gmail.com \
--cc=weiyj.lk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).