From: Bjorn Helgaas <helgaas@kernel.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH -next] PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe()
Date: Mon, 22 Aug 2016 14:38:09 -0500 [thread overview]
Message-ID: <20160822193809.GL18628@localhost> (raw)
In-Reply-To: <1469722634-15049-1-git-send-email-weiyj.lk@gmail.com>
On Thu, Jul 28, 2016 at 04:17:14PM +0000, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Applied with Thomas' reviewed-by to pci/host-aardvark for v4.9, thanks!
> ---
> drivers/pci/host/pci-aardvark.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-aardvark.c b/drivers/pci/host/pci-aardvark.c
> index ef9893f..05c33b5 100644
> --- a/drivers/pci/host/pci-aardvark.c
> +++ b/drivers/pci/host/pci-aardvark.c
> @@ -925,10 +925,8 @@ static int advk_pcie_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> pcie->base = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(pcie->base)) {
> - dev_err(&pdev->dev, "Failed to map registers\n");
> + if (IS_ERR(pcie->base))
> return PTR_ERR(pcie->base);
> - }
>
> irq = platform_get_irq(pdev, 0);
> ret = devm_request_irq(&pdev->dev, irq, advk_pcie_irq_handler,
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2016-08-22 19:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 16:17 [PATCH -next] PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe() Wei Yongjun
2016-07-28 20:17 ` Thomas Petazzoni
2016-08-22 19:38 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822193809.GL18628@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=weiyj.lk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).