From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>, g@localhost.localdomain
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Jon Derrick <jonathan.derrick@intel.com>
Subject: Re: [PATCH v2] vmd: Fix infinite loop executing irq's
Date: Tue, 23 Aug 2016 18:10:43 -0400 [thread overview]
Message-ID: <20160823221042.GA11049@localhost.localdomain> (raw)
In-Reply-To: <20160823213605.GC5838@localhost>
On Tue, Aug 23, 2016 at 04:36:05PM -0500, Bjorn Helgaas wrote:
> On Mon, Aug 08, 2016 at 09:47:51AM -0600, Keith Busch wrote:
> > We can't initialize the list head on deletion as this causes the node
> > to point to itself, looping infinitely if the vmd IRQ handler happened
> > to be servicing that node.
> >
> > The list initialization was trying fix a bug from multiple calls to
> > disable the same IRQ. We can fix this instead by having the vmd driver
> > track if the interrupt is enabled.
> >
> > Signed-off-by: Keith Busch <keith.busch@intel.com>
> > Cc: Jon Derrick <jonathan.derrick@intel.com>
> > Reported-by: Grzegorz Koczot <grzegorz.koczot@intel.com>
> > Tested-by: Miroslaw Drost <miroslaw.drost@intel.com>
>
> I assume you want
>
> Fixes: 97e923063575 ("x86/PCI: VMD: Initialize list item in IRQ disable")
>
> and you want this in for-linus so it goes in v4.8 instead of v4.9.
>
> I did that for you, so let me know if it's not right.
Yes, that was our intention. Thank you for setting the "Fixes" and
staging for 4.8.
prev parent reply other threads:[~2016-08-23 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 15:47 [PATCH v2] vmd: Fix infinite loop executing irq's Keith Busch
2016-08-08 17:05 ` Jon Derrick
2016-08-23 21:36 ` Bjorn Helgaas
2016-08-23 22:10 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823221042.GA11049@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=g@localhost.localdomain \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).