From: Keith Busch <keith.busch@intel.com>
To: Rajat Jain <rajatja@google.com>
Cc: "Patel, Mayurkumar" <mayurkumar.patel@intel.com>,
Bjorn Helgaas <helgaas@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"Tarazona-Duarte,
Luis Antonio" <luis.antonio.tarazona-duarte@intel.com>,
Rajat Jain <rajatxjain@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v1] PCI: pciehp: Fix presence detect change interrupt handling
Date: Wed, 24 Aug 2016 10:59:54 -0400 [thread overview]
Message-ID: <20160824145954.GB13337@localhost.localdomain> (raw)
In-Reply-To: <CACK8Z6GM_zZKvBn4YanWzV_R8TGFErUJboMgvQD5FqUcopOQXg@mail.gmail.com>
On Tue, Aug 23, 2016 at 04:47:44PM -0700, Rajat Jain wrote:
> On Thu, Aug 18, 2016 at 1:59 PM, Patel, Mayurkumar
> <mayurkumar.patel@intel.com> wrote:
> >
> > So does it mean that the port would continue providing MSI if there has been
> > any other events occurred apart from the event which is not cleared? If that
> > is the case then it's not sure why the loop is still needed.
>
> I'd think that the loop is needed because we don't want to handle just
> one event on one interrupt. We want to handle as many events as we can
> (to keep the interrupt latency overhead low), that have happened
> during the ISR invocation. And hence the loop.
The Slot Status doesn't have to provide a single event at a time. But
even if it does, this isn't exactly a performance path that would be
hurt by having one interrupt per event, right?
next prev parent reply other threads:[~2016-08-24 14:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 13:42 [PATCH v1] PCI: pciehp: Fix presence detect change interrupt handling Patel, Mayurkumar
2016-08-17 17:12 ` Bjorn Helgaas
2016-08-17 17:54 ` Rajat Jain
2016-08-17 18:14 ` Bjorn Helgaas
2016-08-17 22:37 ` Patel, Mayurkumar
2016-08-18 12:52 ` Bjorn Helgaas
2016-08-18 20:59 ` Patel, Mayurkumar
2016-08-23 23:47 ` Rajat Jain
2016-08-24 9:00 ` Patel, Mayurkumar
2016-09-01 10:44 ` Patel, Mayurkumar
2016-08-24 14:59 ` Keith Busch [this message]
2016-08-18 21:07 ` [PATCH v1 1/2] " Mayurkumar Patel
2016-08-18 21:07 ` [PATCH v1 2/2] PCI: pciehp: Rework hotplug interrupt routine Mayurkumar Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160824145954.GB13337@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=luis.antonio.tarazona-duarte@intel.com \
--cc=mayurkumar.patel@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rajatja@google.com \
--cc=rajatxjain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).