From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-pci-owner@vger.kernel.org>
Received: from down.free-electrons.com ([37.187.137.238]:34280 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1754607AbcH3QGh (ORCPT
        <rfc822;linux-pci@vger.kernel.org>); Tue, 30 Aug 2016 12:06:37 -0400
Date: Tue, 30 Aug 2016 18:06:33 +0200
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: "Jingoo Han" <jingoohan1@gmail.com>
Cc: "'Joao Pinto'" <jpinto@synopsys.com>,
        "'Bjorn Helgaas'" <bhelgaas@google.com>,
        "'Pratyush Anand'" <pratyush.anand@gmail.com>,
        <linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>,
        "'Rob Herring'" <robh+dt@kernel.org>,
        "'Ian Campbell'" <ijc+devicetree@hellion.org.uk>,
        "'Pawel Moll'" <pawel.moll@arm.com>,
        "'Mark Rutland'" <mark.rutland@arm.com>,
        "'Kumar Gala'" <galak@codeaurora.org>,
        "'Jason Cooper'" <jason@lakedaemon.net>,
        "'Andrew Lunn'" <andrew@lunn.ch>,
        "'Sebastian Hesselbarth'" <sebastian.hesselbarth@gmail.com>,
        "'Gregory Clement'" <gregory.clement@free-electrons.com>,
        <linux-arm-kernel@lists.infradead.org>,
        "'Yehuda Yitschak'" <yehuday@marvell.com>,
        "'Shadi Ammouri'" <shadi@marvell.com>,
        "'Nadav Haklai'" <nadavh@marvell.com>,
        "'Marc Zyngier'" <marc.zyngier@arm.com>
Subject: Re: [PATCH 0/3] pcie-designware: support for external MSI
 controller
Message-ID: <20160830180633.67d6479d@free-electrons.com>
In-Reply-To: <000c01d202d5$a3809bd0$ea81d370$@gmail.com>
References: <1472561830-20932-1-git-send-email-thomas.petazzoni@free-electrons.com>
        <20160830172447.65d10772@free-electrons.com>
        <000c01d202d5$a3809bd0$ea81d370$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-pci-owner@vger.kernel.org
List-ID: <linux-pci.vger.kernel.org>

Hello,

On Tue, 30 Aug 2016 11:46:13 -0400, Jingoo Han wrote:

> > Please discard this patch series, it's just pure crap. No changes at all
> > are needed on the pcie-designware driver, using the msi-parent property
> > already works, and my new code does nothing good.
> > 
> > The of_pci_find_msi_chip_by_node() API is on its way to being removed, and
> > it doesn't return anything useful.
> > 
> > Only PATCH 3/3 is needed, which I'll resubmit separately.
> > 
> > Sorry for the noise.  
> 
> Oh, good.
> The support for External MSI controller is really necessary.
> Thank you for your patch!

Well, no change in the driver is needed to use an external MSI
controller. Just specify:

	msi-parent = <&....>

in the DT description of your Designware PCIe controller. And that's
it. I've tested it with the GIC v2m MSI controller on an ARM64
platform, and it works as expected.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com