linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-pci@vger.kernel.org,
	Pratyush Anand <pratyush.anand@gmail.com>,
	Will Deacon <will.deacon@arm.com>,
	Phil Edworthy <phil.edworthy@renesas.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Rob Herring <robh@kernel.org>,
	Simon Horman <horms+renesas@verge.net.au>,
	Murali Karicheri <m-karicheri2@ti.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH 0/6] PCI: fix pci_remap_iospace() failure paths
Date: Tue, 6 Sep 2016 12:43:57 -0500	[thread overview]
Message-ID: <20160906174357.GC7554@localhost> (raw)
In-Reply-To: <1471279854-11916-1-git-send-email-lorenzo.pieralisi@arm.com>

On Mon, Aug 15, 2016 at 05:50:40PM +0100, Lorenzo Pieralisi wrote:
> On ARM/ARM64 architectures, PCI IO ports are emulated through memory
> mapped IO, by reserving a chunk of virtual address space starting at
> PCI_IOBASE and by mapping the PCI host bridges memory address space
> driving PCI IO cycles to it.
> 
> PCI host bridge drivers that enable downstream PCI IO cycles map the
> host bridge memory address responding to PCI IO cycles to the fixed
> virtual address space through the pci_remap_iospace() API.
> 
> This means that if the pci_remap_iospace() function fails, the
> corresponding host bridge PCI IO resource must be considered invalid, in
> that there is no way for the kernel to actually drive PCI IO transactions
> if the memory addresses responding to PCI IO cycles cannot be mapped into
> the CPU virtual address space.
> 
> As a follow-up to the linux-pci mailing list thread ([0]), this series
> fixes the pci_remap_iospace() failure paths by adding code that handles
> the failures and takes the required actions.
> 
> Compile tested on all affected PCI host controllers, testing and
> reviewing much appreciated.
> 
> [0] http://marc.info/?l=linux-pci&m=145816042427417&w=2
> 
> Lorenzo Pieralisi (6):
>   drivers: pci: host: aardvark: fix pci_remap_iospace() failure path
>   drivers: pci: host: designware: fix pci_remap_iospace() failure path
>   drivers: pci: host: versatile: fix pci_remap_iospace() failure path
>   drivers: pci: host: rcar: fix pci_remap_iospace() failure path
>   drivers: pci: host: common: fix pci_remap_iospace() failure path
>   drivers: pci: host: tegra: fix pci_remap_iospace() failure path
> 
>  drivers/pci/host/pci-aardvark.c    |  8 +++++---
>  drivers/pci/host/pci-host-common.c |  8 +++++---
>  drivers/pci/host/pci-tegra.c       |  7 +++++--
>  drivers/pci/host/pci-versatile.c   |  8 +++++---
>  drivers/pci/host/pcie-designware.c | 21 ++++++++++++---------
>  drivers/pci/host/pcie-rcar.c       |  9 ++++++---
>  6 files changed, 38 insertions(+), 23 deletions(-)

Applied to pci/enumeration for v4.9, thanks!

      parent reply	other threads:[~2016-09-06 17:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-15 16:50 [PATCH 0/6] PCI: fix pci_remap_iospace() failure paths Lorenzo Pieralisi
2016-08-15 16:50 ` [PATCH 1/6] drivers: pci: host: aardvark: fix pci_remap_iospace() failure path Lorenzo Pieralisi
2016-08-15 16:50 ` [PATCH 2/6] drivers: pci: host: designware: " Lorenzo Pieralisi
2016-08-15 16:50 ` [PATCH 3/6] drivers: pci: host: versatile: " Lorenzo Pieralisi
2016-08-15 16:50 ` [PATCH 4/6] drivers: pci: host: rcar: " Lorenzo Pieralisi
2016-08-15 16:50 ` [PATCH 5/6] drivers: pci: host: common: " Lorenzo Pieralisi
2016-08-22 13:21   ` Will Deacon
2016-08-15 16:50 ` [PATCH 6/6] drivers: pci: host: tegra: " Lorenzo Pieralisi
2016-09-06 17:43 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160906174357.GC7554@localhost \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=horms+renesas@verge.net.au \
    --cc=jingoohan1@gmail.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=m-karicheri2@ti.com \
    --cc=phil.edworthy@renesas.com \
    --cc=pratyush.anand@gmail.com \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=treding@nvidia.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).