From: Jon Derrick <jonathan.derrick@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: keith.busch@intel.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] pci/aer: Add bus flag to skip source id matching
Date: Tue, 6 Sep 2016 13:33:26 -0600 [thread overview]
Message-ID: <20160906193325.GA14374@localhost.localdomain> (raw)
In-Reply-To: <20160906192344.GD7554@localhost>
On Tue, Sep 06, 2016 at 02:23:44PM -0500, Bjorn Helgaas wrote:
> On Thu, Aug 25, 2016 at 05:26:10PM -0600, Jon Derrick wrote:
> > Allow root port buses to choose to skip source id matching when finding
> > the faulting device. Certain root port devices may return an incorrect
> > source id and recommend to scan child device registers for aer
> > notifications.
> >
> > Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
>
> Applied both of these to pci/host-vmd for v4.9, thanks!
Thanks!
>
> I think I might even go farther and remove the "nosourceid" module
> parameter. Per Documentation/PCI/pcieaer-howto.txt, it's to work
> around broken hardware, but it's not otherwise documented. With the
> flag you're adding, we could add quirks for that broken hardware,
> which would be far better. I doubt anybody's actually using that
> module parameter.
Yes I'll agree that it makes more sense to call out the nonconforming hardware and have their quirk/fix inbox
prev parent reply other threads:[~2016-09-06 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 23:26 [PATCH 1/2] pci/aer: Add bus flag to skip source id matching Jon Derrick
2016-08-25 23:26 ` [PATCH 2/2] pci/vmd: Add quirk for aer to ignore source id Jon Derrick
2016-09-06 19:23 ` [PATCH 1/2] pci/aer: Add bus flag to skip source id matching Bjorn Helgaas
2016-09-06 19:33 ` Jon Derrick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906193325.GA14374@localhost.localdomain \
--to=jonathan.derrick@intel.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).