From: Jon Derrick <jonathan.derrick@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: keith.busch@intel.com, linux-pci@vger.kernel.org
Subject: Re: [RFC] pci/aer: kmalloc the aer_err_info struct once
Date: Wed, 14 Sep 2016 08:48:29 -0600 [thread overview]
Message-ID: <20160914144826.GA8342@localhost.localdomain> (raw)
In-Reply-To: <20160913213205.GH4138@localhost>
> I like the idea of this. The part I *don't* like is using kmalloc()
> in this path.
>
> We've always done this, and this patch means we would only do it the
> first time for each device, but the struct aer_rpc (which we allocate
> for each device at probe time) is over 900 bytes, while the struct
> aer_err_info is only about 70 bytes. Why don't we just include
> aer_error_info directly in aer_rpc and allocate the whole shebang once
> at probe time? I don't really see what we gain by doing the
> allocation in the runtime path.
Sounds good! Will follow up with a patch
prev parent reply other threads:[~2016-09-14 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 18:35 [RFC] pci/aer: kmalloc the aer_err_info struct once Jon Derrick
2016-09-13 21:32 ` Bjorn Helgaas
2016-09-14 14:48 ` Jon Derrick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914144826.GA8342@localhost.localdomain \
--to=jonathan.derrick@intel.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).