* [PATCH] PCI: artpec6: drop __init from artpec6_add_pcie_port
@ 2016-09-09 7:45 Niklas Cassel
2016-09-14 21:23 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Cassel @ 2016-09-09 7:45 UTC (permalink / raw)
To: bhelgaas, jespern
Cc: linux-arm-kernel, linux-pci, linux-kernel, Niklas Cassel
From: Niklas Cassel <niklas.cassel@axis.com>
artpec6_add_pcie_port is called from artpec6_pcie_probe.
artpec6_pcie_probe does not have the __init section marker.
It is wrong to have the marker on artpec6_add_pcie_port
when the marker is not on artpec6_pcie_probe.
Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
---
drivers/pci/host/pcie-artpec6.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/host/pcie-artpec6.c b/drivers/pci/host/pcie-artpec6.c
index 16ba70b7..39bf1a6 100644
--- a/drivers/pci/host/pcie-artpec6.c
+++ b/drivers/pci/host/pcie-artpec6.c
@@ -191,8 +191,8 @@ static irqreturn_t artpec6_pcie_msi_handler(int irq, void *arg)
return dw_handle_msi_irq(pp);
}
-static int __init artpec6_add_pcie_port(struct pcie_port *pp,
- struct platform_device *pdev)
+static int artpec6_add_pcie_port(struct pcie_port *pp,
+ struct platform_device *pdev)
{
int ret;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: artpec6: drop __init from artpec6_add_pcie_port
2016-09-09 7:45 [PATCH] PCI: artpec6: drop __init from artpec6_add_pcie_port Niklas Cassel
@ 2016-09-14 21:23 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2016-09-14 21:23 UTC (permalink / raw)
To: Niklas Cassel
Cc: bhelgaas, jespern, linux-arm-kernel, linux-pci, linux-kernel,
Niklas Cassel
On Fri, Sep 09, 2016 at 09:45:30AM +0200, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@axis.com>
>
> artpec6_add_pcie_port is called from artpec6_pcie_probe.
> artpec6_pcie_probe does not have the __init section marker.
> It is wrong to have the marker on artpec6_add_pcie_port
> when the marker is not on artpec6_pcie_probe.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Applied to pci/host-artpec for v4.9, thanks!
> ---
> drivers/pci/host/pcie-artpec6.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-artpec6.c b/drivers/pci/host/pcie-artpec6.c
> index 16ba70b7..39bf1a6 100644
> --- a/drivers/pci/host/pcie-artpec6.c
> +++ b/drivers/pci/host/pcie-artpec6.c
> @@ -191,8 +191,8 @@ static irqreturn_t artpec6_pcie_msi_handler(int irq, void *arg)
> return dw_handle_msi_irq(pp);
> }
>
> -static int __init artpec6_add_pcie_port(struct pcie_port *pp,
> - struct platform_device *pdev)
> +static int artpec6_add_pcie_port(struct pcie_port *pp,
> + struct platform_device *pdev)
> {
> int ret;
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-14 21:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-09 7:45 [PATCH] PCI: artpec6: drop __init from artpec6_add_pcie_port Niklas Cassel
2016-09-14 21:23 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).