From: Christoph Hellwig <hch@infradead.org>
To: Adit Ranadive <aditr@vmware.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
pv-drivers <pv-drivers@vmware.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Jorgen S. Hansen" <jhansen@vmware.com>,
Aditya Sarwade <asarwade@vmware.com>,
George Zhang <georgezhang@vmware.com>,
Bryan Tan <bryantan@vmware.com>
Subject: Re: [PATCH v4 05/16] IB/pvrdma: Add functions for Verbs support
Date: Wed, 14 Sep 2016 23:15:37 -0700 [thread overview]
Message-ID: <20160915061537.GC4869@infradead.org> (raw)
In-Reply-To: <BLUPR0501MB836AB8BF5108322033C5DD6C5F00@BLUPR0501MB836.namprd05.prod.outlook.com>
On Thu, Sep 15, 2016 at 12:10:10AM +0000, Adit Ranadive wrote:
> On Wed, Sep 14, 2016 at 05:49:50 -0700 Christoph Hellwig wrote:
> > > + props->max_fmr = dev->dsr->caps.max_fmr;
> > > + props->max_map_per_fmr = dev->dsr->caps.max_map_per_fmr;
> >
> > Please don't add FMR support to any new drivers.
>
> We don't and our device reports these as 0. If you want me to more explicit I
> can remove the zero'd out properties.
Oh, ok. I'll withdraw my comment then.
next prev parent reply other threads:[~2016-09-15 6:15 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 4:49 [PATCH v4 00/16] Add Paravirtual RDMA Driver Adit Ranadive
2016-09-12 4:49 ` [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h Adit Ranadive
2016-09-12 17:21 ` Bjorn Helgaas
2016-09-14 11:08 ` Yuval Shaia
2016-09-14 16:00 ` Adit Ranadive
2016-09-14 16:24 ` Yuval Shaia
2016-09-14 19:36 ` Adit Ranadive
2016-09-15 7:55 ` Yuval Shaia
2016-09-20 13:37 ` Bjorn Helgaas
2016-09-12 4:49 ` [PATCH v4 02/16] IB/pvrdma: Add user-level shared functions Adit Ranadive
2016-09-12 17:49 ` Jason Gunthorpe
2016-09-12 4:49 ` [PATCH v4 03/16] IB/pvrdma: Add virtual device RDMA structures Adit Ranadive
2016-09-12 17:50 ` Jason Gunthorpe
2016-09-12 4:49 ` [PATCH v4 04/16] IB/pvrdma: Add the paravirtual RDMA device specification Adit Ranadive
2016-09-12 4:49 ` [PATCH v4 05/16] IB/pvrdma: Add functions for Verbs support Adit Ranadive
2016-09-14 12:28 ` Yuval Shaia
2016-09-14 12:49 ` Christoph Hellwig
2016-09-15 0:10 ` Adit Ranadive
2016-09-15 6:15 ` Christoph Hellwig [this message]
2016-09-15 7:15 ` Leon Romanovsky
2016-09-12 4:49 ` [PATCH v4 06/16] IB/pvrdma: Add paravirtual rdma device Adit Ranadive
2016-09-14 11:17 ` Yuval Shaia
2016-09-12 4:49 ` [PATCH v4 07/16] IB/pvrdma: Add helper functions Adit Ranadive
2016-09-14 11:21 ` Yuval Shaia
2016-09-12 4:49 ` [PATCH v4 08/16] IB/pvrdma: Add device command support Adit Ranadive
2016-09-12 4:49 ` [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues Adit Ranadive
2016-09-14 12:43 ` Yuval Shaia
2016-09-15 0:07 ` Adit Ranadive
2016-09-15 7:36 ` Yuval Shaia
2016-09-18 17:07 ` Leon Romanovsky
2016-09-18 20:36 ` Adit Ranadive
2016-09-19 3:24 ` Leon Romanovsky
2016-09-12 4:49 ` [PATCH v4 10/16] IB/pvrdma: Add UAR support Adit Ranadive
2016-09-12 4:49 ` [PATCH v4 11/16] IB/pvrdma: Add support for memory regions Adit Ranadive
2016-09-14 12:46 ` Yuval Shaia
2016-09-12 4:49 ` [PATCH v4 12/16] IB/pvrdma: Add Queue Pair support Adit Ranadive
2016-09-14 16:32 ` Yuval Shaia
2016-09-12 4:49 ` [PATCH v4 13/16] IB/pvrdma: Add the main driver module for PVRDMA Adit Ranadive
2016-09-14 16:38 ` Yuval Shaia
2016-09-12 4:49 ` [PATCH v4 14/16] IB/pvrdma: Add Kconfig and Makefile Adit Ranadive
2016-09-12 4:49 ` [PATCH v4 15/16] IB: Add PVRDMA driver Adit Ranadive
2016-09-12 7:32 ` kbuild test robot
2016-09-12 9:00 ` kbuild test robot
2016-09-12 4:49 ` [PATCH v4 16/16] MAINTAINERS: Update for " Adit Ranadive
2016-09-12 17:52 ` Jason Gunthorpe
2016-09-12 22:13 ` Adit Ranadive
2016-09-15 7:27 ` Leon Romanovsky
2016-09-12 18:02 ` [PATCH v4 00/16] Add Paravirtual RDMA Driver Jason Gunthorpe
2016-09-12 22:43 ` Adit Ranadive
2016-09-12 23:16 ` Jason Gunthorpe
2016-09-14 17:36 ` Jason Gunthorpe
2016-09-14 19:44 ` Adit Ranadive
2016-09-14 20:50 ` Jason Gunthorpe
2016-09-14 22:03 ` Woodruff, Robert J
2016-09-14 22:20 ` Woodruff, Robert J
2016-09-14 22:59 ` Jason Gunthorpe
2016-09-16 16:32 ` Jason Gunthorpe
2016-09-16 16:43 ` Woodruff, Robert J
2016-09-15 7:02 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915061537.GC4869@infradead.org \
--to=hch@infradead.org \
--cc=aditr@vmware.com \
--cc=asarwade@vmware.com \
--cc=bryantan@vmware.com \
--cc=dledford@redhat.com \
--cc=georgezhang@vmware.com \
--cc=jhansen@vmware.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).