From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.136]:53756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752145AbcITNhu (ORCPT ); Tue, 20 Sep 2016 09:37:50 -0400 Date: Tue, 20 Sep 2016 08:37:41 -0500 From: Bjorn Helgaas To: Adit Ranadive Cc: Yuval Shaia , "dledford@redhat.com" , "linux-rdma@vger.kernel.org" , pv-drivers , "netdev@vger.kernel.org" , "linux-pci@vger.kernel.org" , "Jorgen S. Hansen" , Aditya Sarwade , George Zhang , Bryan Tan Subject: Re: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h Message-ID: <20160920133741.GC13855@localhost> References: <1473655766-31628-1-git-send-email-aditr@vmware.com> <1473655766-31628-2-git-send-email-aditr@vmware.com> <20160914110854.GA15800@yuval-lap.uk.oracle.com> <20160914162452.GA3216@yuval-lap.Home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, Sep 14, 2016 at 07:36:34PM +0000, Adit Ranadive wrote: > On Wed, Sep 14, 2016 at 09:25:18 -0700, Yuval Shaia wrote: > > On Wed, Sep 14, 2016 at 04:00:25PM +0000, Adit Ranadive wrote: > > > On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote: > > > > Please update vmxnet3_drv.c accordingly. > > > > > > Any reason why? I don't think we need to. Vmxnet3 should just pick up > > > the moved PCI device id from pci_ids.h file. > > > > So now you need to include it from vmxnet3_drv.c. > > Same with pvrdma_main.c > > If you're asking me to include pci_ids.h in our drivers we already do that > by including pci.h in both the drivers. > pci.h already includes pci_ids.h - > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/linux/pci.h#n35 > > If that's going to change maybe someone from the PCI group can comment on. I don't contemplate a change there. It's fine to get pci_ids.h via pci.h. Almost all drivers do that today. If we do change it someday, we can change this driver along with all the rest. Bjorn