linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>,
	hans.verkuil@cisco.com, brking@us.ibm.com,
	haver@linux.vnet.ibm.com, ching2048@areca.com.tw, axboe@fb.com,
	alex.williamson@redhat.com, kvm@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
	linux-media@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] ipr: use pci_irq_allocate_vectors
Date: Thu, 29 Sep 2016 17:32:37 +0200	[thread overview]
Message-ID: <20160929153237.GA32512@lst.de> (raw)
In-Reply-To: <200e5b3f-8555-9cd3-7940-0ec0f2867b95@linux.vnet.ibm.com>

On Thu, Sep 29, 2016 at 09:01:44AM -0500, Brian King wrote:
> Thanks Christoph. Very nice. As I was reviewing the patch, I noticed
> the additional PCI_IRQ_AFFINITY flag, which is currently not being set
> in this patch. Is the intention to set that globally by default, or
> should I follow up with a one liner to add that to the ipr driver
> in the next patch set I send out?

Hi Brian,

PCI_IRQ_AFFINITY seems useful for ipr, especially if you also increase
the number of vectors above the current default 2.  And yes, please
make it a separate patch.

  reply	other threads:[~2016-09-29 15:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-11 13:31 replace pci_enable_msi_{exact_range} with pci_alloc_irq_vectors Christoph Hellwig
2016-09-11 13:31 ` [PATCH 1/6] arcmsr: use pci_alloc_irq_vectors Christoph Hellwig
2016-09-19 20:45   ` Martin K. Petersen
2016-10-11 20:16   ` Martin K. Petersen
2016-09-11 13:31 ` [PATCH 2/6] ipr: use pci_irq_allocate_vectors Christoph Hellwig
2016-09-19 20:44   ` Martin K. Petersen
2016-09-29 14:01   ` Brian King
2016-09-29 15:32     ` Christoph Hellwig [this message]
2016-10-11 20:18   ` Martin K. Petersen
2016-09-11 13:31 ` [PATCH 3/6] skd: use pci_alloc_irq_vectors Christoph Hellwig
2016-09-11 13:31 ` [PATCH 4/6] vfio_pci: use pci_irq_allocate_vectors Christoph Hellwig
2016-09-29 18:42   ` Christoph Hellwig
2016-09-29 19:21   ` Alex Williamson
2016-09-29 19:24     ` Christoph Hellwig
2016-09-29 19:27       ` Alex Williamson
2016-09-11 13:31 ` [PATCH 5/6] genwqe: " Christoph Hellwig
2016-09-29 18:28   ` Gabriel Krisman Bertazi
2016-09-29 18:37     ` Christoph Hellwig
2016-09-29 18:45       ` Gabriel Krisman Bertazi
2016-09-29 18:48         ` Christoph Hellwig
2016-09-29 18:51           ` Gabriel Krisman Bertazi
2016-09-11 13:31 ` [PATCH 6/6] media/cobalt: " Christoph Hellwig
2016-09-16  8:01   ` Hans Verkuil
2016-09-16  8:31     ` Christoph Hellwig
2016-12-14 10:29     ` Christoph Hellwig
2016-12-14 10:37       ` Hans Verkuil
2016-12-14 10:47         ` Christoph Hellwig
2016-12-14 10:52           ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160929153237.GA32512@lst.de \
    --to=hch@lst.de \
    --cc=alex.williamson@redhat.com \
    --cc=axboe@fb.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=brking@us.ibm.com \
    --cc=ching2048@areca.com.tw \
    --cc=hans.verkuil@cisco.com \
    --cc=haver@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).