From: Keith Busch <keith.busch@intel.com>
To: Jon Derrick <jonathan.derrick@intel.com>
Cc: helgaas@kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI/VMD: Use the more reliable method for setting the AER
Date: Fri, 7 Oct 2016 13:45:49 -0400 [thread overview]
Message-ID: <20161007174548.GA4746@localhost.localdomain> (raw)
In-Reply-To: <1475861189-10794-1-git-send-email-jonathan.derrick@intel.com>
On Fri, Oct 07, 2016 at 11:26:28AM -0600, Jon Derrick wrote:
> Instead of relying on the domain being >= 0x10000, use the member of the
> pci sysdata that identifies a VMD root port bus.
'is_vmd' is only defined for x86. You'll need a '#define is_vmd' to
false in some arch generic place.
> ---
> drivers/pci/quirks.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index edc7f96..713035f 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -4438,8 +4438,7 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x443, quirk_intel_qat_vf_cap);
> */
> static void quirk_no_aersid(struct pci_dev *pdev)
> {
> - /* VMD Domain */
> - if (pdev->bus->sysdata && pci_domain_nr(pdev->bus) >= 0x10000)
> + if (is_vmd(pdev->bus))
> pdev->bus->bus_flags |= PCI_BUS_FLAGS_NO_AERSID;
> }
> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2030, quirk_no_aersid);
next prev parent reply other threads:[~2016-10-07 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 17:26 [PATCH 1/2] PCI/VMD: Use the more reliable method for setting the AER Jon Derrick
2016-10-07 17:26 ` [PATCH 2/2] PCI/Quirks: Imply that other users can use the no-aer-sid quirk Jon Derrick
2016-10-07 17:45 ` Keith Busch [this message]
2016-10-07 17:46 ` [PATCH 1/2] PCI/VMD: Use the more reliable method for setting the AER Jon Derrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007174548.GA4746@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox