From: Lukas Wunner <lukas@wunner.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 1/1] x86/platform/intel-mid: Retrofit pci_platform_pm_ops ->get_power hook
Date: Sun, 9 Oct 2016 12:46:26 +0200 [thread overview]
Message-ID: <20161009104626.GA8299@wunner.de> (raw)
In-Reply-To: <1475873734.11323.324.camel@linux.intel.com>
On Fri, Oct 07, 2016 at 11:55:34PM +0300, Andy Shevchenko wrote:
> On Thu, 2016-10-06 at 08:24 +0200, Lukas Wunner wrote:
> > +
> > + reg = (id * LSS_PWS_BITS) / 32;
> > + bit = (id * LSS_PWS_BITS) % 32;
> > + power = mid_pwr_get_state(pwr, reg);
> > + return (power >> bit) & 3;
>
> Don't add sparse warnings:
>
> return (__force pci_power_t)((power >> bit) & 3);
I do not get any different sparse warnings with or without the cast
despite using -Wsparse-all. This is with sparse 0.5.0 as included in
Debian stretch.
With which options and sparse version did you manage to get new warnings?
Thanks,
Lukas
next prev parent reply other threads:[~2016-10-09 10:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 6:24 [PATCH 0/1] x86/platform/intel-mid: Retrofit pci_platform_pm_ops Lukas Wunner
2016-10-06 6:24 ` [PATCH 1/1] x86/platform/intel-mid: Retrofit pci_platform_pm_ops ->get_power hook Lukas Wunner
2016-10-07 20:55 ` Andy Shevchenko
2016-10-08 13:49 ` Lukas Wunner
2016-10-09 12:26 ` Andy Shevchenko
2016-10-09 15:03 ` Lukas Wunner
2016-10-10 10:54 ` Andy Shevchenko
2016-10-09 10:46 ` Lukas Wunner [this message]
2016-10-09 11:57 ` Andy Shevchenko
2016-10-09 12:49 ` Lukas Wunner
2016-10-07 20:55 ` [PATCH 0/1] x86/platform/intel-mid: Retrofit pci_platform_pm_ops Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161009104626.GA8299@wunner.de \
--to=lukas@wunner.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).