From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/8] PCI: armada: Name private struct pointer "armada8k" consistently
Date: Mon, 10 Oct 2016 12:17:31 -0500 [thread overview]
Message-ID: <20161010171731.GB12748@localhost> (raw)
In-Reply-To: <20161007221717.72f45013@free-electrons.com>
On Fri, Oct 07, 2016 at 10:17:17PM +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Fri, 07 Oct 2016 11:31:18 -0500, Bjorn Helgaas wrote:
> > Use a device-specific name, "armada8k", for struct armada8k_pcie pointers
> > to hint that this is device-specific information. No functional change
> > intended.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > ---
> > drivers/pci/host/pcie-armada8k.c | 37 ++++++++++++++++++-------------------
> > 1 file changed, 18 insertions(+), 19 deletions(-)
>
> For the entire series:
>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> However, I don't have access to HW right now to test. I can give some
> testing when I get back to the office.
I made tweaks similar to the aardvark ones to this branch.
prev parent reply other threads:[~2016-10-10 17:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 16:31 [PATCH 1/8] PCI: armada: Name private struct pointer "armada8k" consistently Bjorn Helgaas
2016-10-07 16:31 ` [PATCH 2/8] PCI: armada: Add register accessors Bjorn Helgaas
2016-10-07 16:31 ` [PATCH 3/8] PCI: armada: Remove redundant struct armada8k_pcie.base Bjorn Helgaas
2016-10-07 16:31 ` [PATCH 4/8] PCI: armada: Pass device-specific struct to internal functions Bjorn Helgaas
2016-10-07 16:31 ` [PATCH 5/8] PCI: armada: Reorder struct armada8k_pcie Bjorn Helgaas
2016-10-07 16:32 ` [PATCH 6/8] PCI: armada: Replace armada8k_readl() with dw_pcie_readl_rc() Bjorn Helgaas
2016-10-07 16:32 ` [PATCH 7/8] PCI: armada: Reorder local declaration Bjorn Helgaas
2016-10-07 16:32 ` [PATCH 8/8] PCI: armada: Remove unused platform data Bjorn Helgaas
2016-10-07 20:17 ` [PATCH 1/8] PCI: armada: Name private struct pointer "armada8k" consistently Thomas Petazzoni
2016-10-10 17:17 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010171731.GB12748@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).