From: Bjorn Helgaas <bhelgaas@google.com>
To: Minghuan Lian <minghuan.Lian@freescale.com>,
Mingkai Hu <mingkai.hu@freescale.com>,
Roy Zang <tie-fei.zang@freescale.com>
Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v2 4/7] PCI: layerscape: Pass device-specific struct to internal functions
Date: Wed, 12 Oct 2016 08:57:54 -0500 [thread overview]
Message-ID: <20161012135754.29815.59676.stgit@bhelgaas-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20161012135413.29815.75484.stgit@bhelgaas-glaptop2.roam.corp.google.com>
Only interfaces used from outside the driver, e.g., those called by the
DesignWare core, need to accept pointers to the generic struct pcie_port.
Internal interfaces can accept pointers to the device-specific struct,
which makes them more straightforward. No functional change intended.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/host/pci-layerscape.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c
index bdafe55..2b31296 100644
--- a/drivers/pci/host/pci-layerscape.c
+++ b/drivers/pci/host/pci-layerscape.c
@@ -213,12 +213,12 @@ static const struct of_device_id ls_pcie_of_match[] = {
{ },
};
-static int __init ls_add_pcie_port(struct pcie_port *pp,
+static int __init ls_add_pcie_port(struct ls_pcie *pcie,
struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
+ struct pcie_port *pp = &pcie->pp;
int ret;
- struct ls_pcie *pcie = to_ls_pcie(pp);
pp->dev = dev;
pp->ops = pcie->drvdata->ops;
@@ -261,7 +261,7 @@ static int __init ls_pcie_probe(struct platform_device *pdev)
if (!ls_pcie_is_bridge(pcie))
return -ENODEV;
- ret = ls_add_pcie_port(&pcie->pp, pdev);
+ ret = ls_add_pcie_port(pcie, pdev);
if (ret < 0)
return ret;
next prev parent reply other threads:[~2016-10-12 13:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 13:57 [PATCH v2 0/7] PCI: layerscape: Cleanups Bjorn Helgaas
2016-10-12 13:57 ` [PATCH v2 1/7] PCI: layerscape: Add local struct device pointers Bjorn Helgaas
2016-10-12 13:57 ` [PATCH v2 2/7] PCI: layerscape: Remove unused platform data Bjorn Helgaas
2016-10-12 13:57 ` [PATCH v2 3/7] PCI: layerscape: Remove redundant struct ls_pcie.dbi Bjorn Helgaas
2016-10-12 13:57 ` Bjorn Helgaas [this message]
2016-10-12 13:58 ` [PATCH v2 5/7] PCI: layerscape: Move struct pcie_port setup to probe function Bjorn Helgaas
2016-10-12 13:58 ` [PATCH v2 6/7] PCI: layerscape: Remove unused ls_add_pcie_port() platform_device arg Bjorn Helgaas
2016-10-12 13:58 ` [PATCH v2 7/7] PCI: layerscape: Reorder struct ls_pcie Bjorn Helgaas
2016-10-12 16:06 ` [PATCH v2 0/7] PCI: layerscape: Cleanups Bjorn Helgaas
2016-10-12 16:32 ` Roy Zang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012135754.29815.59676.stgit@bhelgaas-glaptop2.roam.corp.google.com \
--to=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minghuan.Lian@freescale.com \
--cc=mingkai.hu@freescale.com \
--cc=tie-fei.zang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox