From: Bjorn Helgaas <helgaas@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Duc Dang <dhdang@apm.com>, Tanmay Inamdar <tinamdar@apm.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 0/4] PCI: xgene: Cleanups
Date: Wed, 12 Oct 2016 11:03:00 -0500 [thread overview]
Message-ID: <20161012160300.GH4308@localhost> (raw)
In-Reply-To: <20161012130508.25368.95560.stgit@bhelgaas-glaptop2.roam.corp.google.com>
On Wed, Oct 12, 2016 at 08:07:35AM -0500, Bjorn Helgaas wrote:
> - Add local "dev" pointers to reduce repetition of things like
> "&pdev->dev".
>
> - Remove platform drvdata because it appears unused (we called
> platform_set_drvdata() but not platform_get_drvdata()).
>
> - Pass the struct xgene_pcie_port pointer, not addresses, to setup
> functions to enable simplifications.
>
> - Add register accessors to encapsulate usage of port->csr_base a bit.
>
> Nothing here should change the behavior of the driver.
>
> Changes from v1:
> I dropped the following patch because it was a lot of churn for
> questionable benefit:
> PCI: xgene: Name private struct pointer "xgene" consistently
>
> ---
>
> Bjorn Helgaas (4):
> PCI: xgene: Add local struct device pointers
> PCI: xgene: Remove unused platform data
> PCI: xgene: Pass struct xgene_pcie_port to setup functions
> PCI: xgene: Add register accessors
I applied these to pci/host-xgene for v4.9. I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.
next prev parent reply other threads:[~2016-10-12 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 13:07 [PATCH v2 0/4] PCI: xgene: Cleanups Bjorn Helgaas
2016-10-12 13:07 ` [PATCH v2 1/4] PCI: xgene: Add local struct device pointers Bjorn Helgaas
2016-10-12 13:07 ` [PATCH v2 2/4] PCI: xgene: Remove unused platform data Bjorn Helgaas
2016-10-12 13:07 ` [PATCH v2 3/4] PCI: xgene: Pass struct xgene_pcie_port to setup functions Bjorn Helgaas
2016-10-12 13:08 ` [PATCH v2 4/4] PCI: xgene: Add register accessors Bjorn Helgaas
2016-10-12 16:03 ` Bjorn Helgaas [this message]
2016-10-12 23:20 ` [PATCH v2 0/4] PCI: xgene: Cleanups Duc Dang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012160300.GH4308@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=dhdang@apm.com \
--cc=linux-pci@vger.kernel.org \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox