Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>,
	Niklas Cassel <niklas.cassel@axis.com>,
	linux-pci@vger.kernel.org, linux-arm-kernel@axis.com
Subject: Re: [PATCH v2 0/7] PCI: artpec: Cleanups
Date: Wed, 12 Oct 2016 11:04:40 -0500	[thread overview]
Message-ID: <20161012160440.GL4308@localhost> (raw)
In-Reply-To: <20161012132616.27228.4618.stgit@bhelgaas-glaptop2.roam.corp.google.com>

On Wed, Oct 12, 2016 at 08:28:55AM -0500, Bjorn Helgaas wrote:
>   - Add local "dev" pointers to reduce repetition of things like
>     "&pdev->dev".
> 
>   - Remove platform drvdata because it appears unused (we called
>     platform_set_drvdata() but not platform_get_drvdata()).
> 
>   - Use generic DesignWare accessors when possible.
> 
>   - Add register accessors to encapsulate regmap usage.
> 
>   - Pass device-specific struct to internal functions for consistency.
> 
> Nothing here should change the behavior of the driver.
> 
> Changes from v1:
>   I dropped the following patch because it was a lot of churn for
>   questionable benefit:
>     PCI: artpec6: Name private struct pointer "artpec6" consistently
> 
> ---
> 
> Bjorn Helgaas (7):
>       PCI: artpec6: Add local struct device pointers
>       PCI: artpec6: Remove unused platform data
>       PCI: artpec6: Add register accessors
>       PCI: artpec6: Use generic DesignWare accessors
>       PCI: artpec6: Remove unnecessary artpec6_pcie_link_up()
>       PCI: artpec6: Pass device-specific struct to internal functions
>       PCI: artpec6: Add resource name comments
> 
> 
>  drivers/pci/host/pcie-artpec6.c |  115 ++++++++++++++++++++-------------------
>  1 file changed, 59 insertions(+), 56 deletions(-)

I applied these to pci/host-artpec for v4.9.  I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.

  parent reply	other threads:[~2016-10-12 16:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12 13:28 [PATCH v2 0/7] PCI: artpec: Cleanups Bjorn Helgaas
2016-10-12 13:29 ` [PATCH v2 1/7] PCI: artpec6: Add local struct device pointers Bjorn Helgaas
2016-10-12 13:29 ` [PATCH v2 2/7] PCI: artpec6: Remove unused platform data Bjorn Helgaas
2016-10-12 13:29 ` [PATCH v2 3/7] PCI: artpec6: Add register accessors Bjorn Helgaas
2016-10-12 13:29 ` [PATCH v2 4/7] PCI: artpec6: Use generic DesignWare accessors Bjorn Helgaas
2016-10-12 13:29 ` [PATCH v2 5/7] PCI: artpec6: Remove unnecessary artpec6_pcie_link_up() Bjorn Helgaas
2016-10-12 13:29 ` [PATCH v2 6/7] PCI: artpec6: Pass device-specific struct to internal functions Bjorn Helgaas
2016-10-12 13:29 ` [PATCH v2 7/7] PCI: artpec6: Add resource name comments Bjorn Helgaas
2016-10-12 16:04 ` Bjorn Helgaas [this message]
2016-10-12 20:40   ` [PATCH v2 0/7] PCI: artpec: Cleanups Jesper Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161012160440.GL4308@localhost \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=jesper.nilsson@axis.com \
    --cc=linux-arm-kernel@axis.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=niklas.cassel@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox