From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-pci-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.136]:60444 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753932AbcJLQFd (ORCPT <rfc822;linux-pci@vger.kernel.org>);
        Wed, 12 Oct 2016 12:05:33 -0400
Date: Wed, 12 Oct 2016 11:05:28 -0500
From: Bjorn Helgaas <helgaas@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Kukjin Kim <kgene@kernel.org>, linux-pci@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 0/5] PCI: exynos: Cleanups
Message-ID: <20161012160528.GN4308@localhost>
References: <20161012133428.28194.54006.stgit@bhelgaas-glaptop2.roam.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <20161012133428.28194.54006.stgit@bhelgaas-glaptop2.roam.corp.google.com>
Sender: linux-pci-owner@vger.kernel.org
List-ID: <linux-pci.vger.kernel.org>

On Wed, Oct 12, 2016 at 08:37:07AM -0500, Bjorn Helgaas wrote:
>   - Add local "dev" pointers to reduce repetition of things like
>     "&pdev->dev".
> 
>   - Name private struct pointer consistently within driver.
> 
>   - Pass device-specific struct to internal functions for consistency.
> 
> Nothing here should change the behavior of the driver.
> 
> Changes from v1:
>   I dropped the following patches because they were a lot of churn for
>   questionable benefit:
>     PCI: exynos: Name private struct pointer "exynos" consistently
>       (Instead of renaming *all* the pointers, I only renamed enough to
>       make them consistent within this file.)
>     PCI: exynos: Swap order of exynos_elb_writel() reg/val arguments
>     PCI: exynos: Swap order of exynos_phy_writel() reg/val arguments
>     PCI: exynos: Swap order of exynos_blk_writel() reg/val arguments
> 
> ---
> 
> Bjorn Helgaas (5):
>       PCI: exynos: Add local struct device pointers
>       PCI: exynos: Uninline register accessors
>       PCI: exynos: Name private struct pointer "exynos_pcie" consistently
>       PCI: exynos: Pass device-specific struct to internal functions
>       PCI: exynos: Reorder struct exynos_pcie
> 
> 
>  drivers/pci/host/pci-exynos.c |  214 +++++++++++++++++++----------------------
>  1 file changed, 100 insertions(+), 114 deletions(-)

I applied these to pci/host-exynos for v4.9.  I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.