Re: [PATCH v2 0/8] PCI: hisi: Cleanups

[Bjorn Helgaas <helgaas@kernel.org>]

On Wed, Oct 12, 2016 at 08:42:27AM -0500, Bjorn Helgaas wrote:
>   - Add local "dev" pointers to reduce repetition of things like
>     "&pdev->dev".
> 
>   - Remove platform drvdata because it appears unused (we called
>     platform_set_drvdata() but not platform_get_drvdata()).
> 
>   - Name private struct pointer consistently within driver.
> 
>   - Remove redundant struct members.
> 
>   - Use generic DesignWare accessors when possible.
> 
>   - Pass device-specific struct to internal functions for consistency.
> 
>   - Include register block base in PCIE_SYS_STATE4 address to simplify
>     users.
> 
> Nothing here should change the behavior of the driver.
> 
> Changes from v1:
>   I dropped the following patches because they were a lot of churn for
>   questionable benefit:
>     PCI: hisi: Rename APB accessors
>     PCI: hisi: Rename config accessors
>     PCI: hisi: Name private struct pointer "hisi" consistently
>       (Instead of renaming *all* the pointers, I only renamed enough to
>       make them consistent within this file.)
>     PCI: hisi: Swap order of hisi_apb_writel() reg/val arguments
> 
> ---
> 
> Bjorn Helgaas (8):
>       PCI: hisi: Add local struct device pointers
>       PCI: hisi: Remove unused platform data
>       PCI: hisi: Name private struct pointer "hisi_pcie" consistently
>       PCI: hisi: Remove redundant struct hisi_pcie.reg_base
>       PCI: hisi: Use generic DesignWare accessors
>       PCI: hisi: Include register block base in PCIE_SYS_STATE4 address
>       PCI: hisi: Pass device-specific struct to internal functions
>       PCI: hisi: Reorder struct hisi_pcie
> 
> 
>  drivers/pci/host/pcie-hisi.c |   86 +++++++++++++++++-------------------------
>  1 file changed, 35 insertions(+), 51 deletions(-)

I applied these to pci/host-hisi for v4.9.  I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.