From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.136]:35410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754910AbcJLQ0j (ORCPT ); Wed, 12 Oct 2016 12:26:39 -0400 Date: Wed, 12 Oct 2016 11:18:42 -0500 From: Bjorn Helgaas To: Ray Jui Cc: Bjorn Helgaas , Jon Mason , Ray Jui , Scott Branden , linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v2 0/5] PCI: iproc: Cleanups Message-ID: <20161012161842.GW4308@localhost> References: <20161012124804.24076.48957.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20161012160114.GC4308@localhost> <4e1e4df1-15b0-7deb-eaa9-4ac683812be9@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4e1e4df1-15b0-7deb-eaa9-4ac683812be9@broadcom.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, Oct 12, 2016 at 09:04:26AM -0700, Ray Jui wrote: > Hi Bjorn, > > On 10/12/2016 9:01 AM, Bjorn Helgaas wrote: > >On Wed, Oct 12, 2016 at 07:53:03AM -0500, Bjorn Helgaas wrote: > >> - Add local "dev" pointers to reduce repetition of things like > >> "&pdev->dev". > >> > >> - Tidy up drvdata usage. > >> > >> - Remove some null pointer checking after adding corresponding checking > >> elsewhere. > >> > >> - Hard-code the PCIe capability offset instead of searching for it. This > >> removes a little bit of dependency on struct pci_bus, with an eye > >> toward moving the link maintenance before enumeration. > >> > >>Changes from v1: > >> I dropped the following patches because they were a lot of churn for > >> questionable benefit: > >> PCI: iproc: Rename accessors > >> PCI: iproc: Name private struct pointer "iproc" consistently > >> > >>--- > >> > >>Bjorn Helgaas (5): > >> PCI: iproc: Add local struct device pointers > >> PCI: iproc: Set drvdata at end of probe function > >> PCI: iproc: Validate CSR base in BCMA setup code > >> PCI: iproc: Remove redundant null pointer checking > >> PCI: iproc: Hard-code PCIe capability offset instead of searching > > > >I applied these to pci/host-iproc for v4.9. I hope to ask Linus to > >pull them tomorrow, so if you see any issues, let me know soon. > > > > That sounds good. Are these patches in the git repo: > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git at > branch pci/host-iproc? They should be there. I also just merged everything into my "next" branch. > I plan to sanity test them on various iProc based SoCs. Great, thanks!