From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.136]:52548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934220AbcJMSvh (ORCPT ); Thu, 13 Oct 2016 14:51:37 -0400 Date: Thu, 13 Oct 2016 13:27:29 -0500 From: Bjorn Helgaas To: Murali Karicheri Cc: Bjorn Helgaas , linux-pci@vger.kernel.org Subject: Re: [PATCH v2 0/6] PCI: keystone: Cleanups Message-ID: <20161013182729.GD21529@localhost> References: <20161012134953.29306.24609.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20161012160622.GQ4308@localhost> <57FFCADE.7040300@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <57FFCADE.7040300@ti.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Thu, Oct 13, 2016 at 01:56:46PM -0400, Murali Karicheri wrote: > On 10/12/2016 12:06 PM, Bjorn Helgaas wrote: > > On Wed, Oct 12, 2016 at 08:53:00AM -0500, Bjorn Helgaas wrote: > >> - Add local "dev" pointers to reduce repetition of things like > >> "&pdev->dev". > >> > >> - Use generic DesignWare accessors when possible. > >> > >> - Pass device-specific struct instead of register addresses to IRQ and > >> DBI functions. > >> > >> - Add app register accessors to encapsulate usage of va_app_base. > >> > >> Nothing here should change the behavior of the driver. > >> > >> Changes from v1: > >> Added local struct device pointers. > >> I dropped the following patch because it was a lot of churn for > >> questionable benefit: > >> PCI: keystone: Name private struct pointer "keystone" consistently > >> > >> --- > >> > >> Bjorn Helgaas (6): > >> PCI: keystone: Add local struct device pointers > >> PCI: keystone: Use generic DesignWare accessors > >> PCI: keystone: Pass keystone_pcie, not address, to IRQ functions > >> PCI: keystone: Pass keystone_pcie, not va_app_base, to DBI functions > >> PCI: keystone: Add app register accessors > >> PCI: keystone: Reorder struct keystone_pcie > >> > >> > >> drivers/pci/host/pci-keystone-dw.c | 123 ++++++++++++++++++++---------------- > >> drivers/pci/host/pci-keystone.c | 28 ++++---- > >> drivers/pci/host/pci-keystone.h | 9 +-- > >> 3 files changed, 88 insertions(+), 72 deletions(-) > > > > I applied these to pci/host-keystone for v4.9. I hope to ask Linus to > > pull them tomorrow, so if you see any issues, let me know soon. > > > Bjorn, > > I have reviewed them and they look good to me. For testing, I am in the > middle of a high visibility debug and it will be a while before I can test > these. Thanks a lot, Murali! No hurry; if I broke something, we can fix it during the rest of the cycle. Bjorn