From: Keith Busch <keith.busch@intel.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-pci@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
David Arcari <darcari@redhat.com>,
Myron Stowe <mstowe@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [RFE PATCH] pci: Do not enable intx on MSI-capable devices on shutdown
Date: Tue, 25 Oct 2016 18:16:13 -0400 [thread overview]
Message-ID: <20161025221613.GA32365@localhost.localdomain> (raw)
In-Reply-To: <580FADC6.1020407@redhat.com>
On Tue, Oct 25, 2016 at 03:08:54PM -0400, Prarit Bhargava wrote:
> When pci_disable_msi() is currently called the result is that device is
> switched back to intx and then the MSI IRQs are free'd. This patch would
> modify that behavior, and intx would not be reenabled when pci_disable_msix()
> was called during runtime. With the system_state patch we're only affecting
> shutdown, which is seen as less risky than doing
My proposal isn't really modifying exisiting behavior since if it does,
the currently in place expectations are being violated: if anyone calls
"pci_disable_msi" with actions on the irqs being disabled, they're
already screwed since they will hit the BUG_ON in free_msi_irqs.
next prev parent reply other threads:[~2016-10-25 22:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 12:14 [RFE PATCH] pci: Do not enable intx on MSI-capable devices on shutdown Prarit Bhargava
2016-10-24 9:44 ` Lukas Wunner
2016-10-24 13:52 ` Prarit Bhargava
2016-10-25 18:08 ` Keith Busch
2016-10-25 19:08 ` Prarit Bhargava
2016-10-25 22:16 ` Keith Busch [this message]
2016-10-26 14:00 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025221613.GA32365@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=darcari@redhat.com \
--cc=linux-pci@vger.kernel.org \
--cc=mstowe@redhat.com \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).